Skip to content

Port TestFileTaskLogHandler tests to new Structlog logs #50977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
kaxil opened this issue May 22, 2025 · 0 comments · May be fixed by #50990
Open
1 task done

Port TestFileTaskLogHandler tests to new Structlog logs #50977

kaxil opened this issue May 22, 2025 · 0 comments · May be fixed by #50990
Labels
area:CI Airflow's tests and continious integration area:logging kind:meta High-level information important to the community

Comments

@kaxil
Copy link
Member

kaxil commented May 22, 2025

Body

Fix the following

airflow/airflow-core/tests/unit/utils/test_log_handlers.py

Lines 108 to 109 in 7c2c886

@pytest.mark.xfail(reason="TODO: Needs to be ported over to the new structlog based logging")
def test_file_task_handler_when_ti_value_is_invalid(self, dag_maker):

airflow/airflow-core/tests/unit/utils/test_log_handlers.py

Lines 153 to 154 in 7c2c886

@pytest.mark.xfail(reason="TODO: Needs to be ported over to the new structlog based logging")
def test_file_task_handler(self, dag_maker, session):

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@kaxil kaxil added the kind:meta High-level information important to the community label May 22, 2025
@kaxil kaxil mentioned this issue May 22, 2025
Merged
@dosubot dosubot bot added area:CI Airflow's tests and continious integration area:logging labels May 22, 2025
highlyavailable added a commit to highlyavailable/airflow that referenced this issue May 23, 2025
@highlyavailable
Port TestFileTaskLogHandler tests to new Structlog logs - Remove xfai…
f7f3dc0 
…l decorators and update assertions for StructuredLogMessage objects (fixes apache#50977)
@highlyavailable highlyavailable linked a pull request May 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:CI Airflow's tests and continious integration area:logging kind:meta High-level information important to the community
Projects
AIP-72 - Task Execution Interface and SDK
Status: Icebox
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Port TestFileTaskLogHandler tests to new Structlog logs highlyavailable/airflow
1 participant
@kaxil
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy