Skip to content

feat(schematics): support --skip-install for ng-add #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JamesHenry
Copy link
Member

Summary

  • add skipInstall schema option for ng-add
  • document new flag and usage example
  • allow --skip-install to skip NodePackageInstallTask
  • log install instructions when skipping dependencies

Testing

  • pnpm jest packages/schematics --runInBand
  • pnpm format-check
  • pnpm nx sync:check
  • NX_NO_CLOUD=true pnpm nx run-many -t check-rule-docs --parallel=1
  • NX_NO_CLOUD=true pnpm nx run-many -t check-rule-lists --parallel=1
  • NX_NO_CLOUD=true pnpm nx run-many -t check-rule-configs --parallel=1

Copy link

nx-cloud bot commented May 25, 2025

View your CI Pipeline Execution ↗ for commit 2ea5e90.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 13s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 12s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 36s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 2s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 5s View ↗
nx run-many -t test ✅ Succeeded 12s View ↗
nx run-many -t build ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-25 08:30:43 UTC

Copy link

codecov bot commented May 25, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.80%. Comparing base (2ef4cb3) to head (2ea5e90).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/schematics/src/ng-add/index.ts 60.00% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (60.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2451      +/-   ##
==========================================
- Coverage   92.84%   92.80%   -0.05%     
==========================================
  Files         195      195              
  Lines        4083     4085       +2     
  Branches      951      952       +1     
==========================================
  Hits         3791     3791              
- Misses        225      226       +1     
- Partials       67       68       +1     
Flag Coverage Δ
unittest 92.80% <60.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/schematics/src/ng-add/index.ts 75.60% <60.00%> (-1.90%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JamesHenry JamesHenry marked this pull request as ready for review May 25, 2025 09:13
@JamesHenry JamesHenry merged commit 024b37a into main May 25, 2025
6 of 7 checks passed
@JamesHenry JamesHenry deleted the codex/add---skip-install-option-to-ng-add-schematic branch May 25, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy