Skip to content

Revert "fix(core): call DestroyRef on destroy callback if view is d… #61625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Revert "fix(core): call DestroyRef on destroy callback if view is d… #61625

wants to merge 2 commits into from
+26 −62

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented May 22, 2025 •
edited
Loading

…estroyed (#58008)"

This reverts commit 5f7f046.

The rationale behind reverting the change is following:

@pullapprove pullapprove bot requested a review from atscott May 22, 2025 18:12
@JeanMeche JeanMeche mentioned this pull request May 22, 2025
Closed
@JeanMeche JeanMeche added the target: rc This PR is targeted for the next release-candidate label May 22, 2025
@atscott atscott added the requires: TGP This PR requires a passing TGP before merging is allowed label May 22, 2025
@atscott atscott added this to the v20 candidates milestone May 22, 2025
@ngbot ngbot bot removed this from the v20 candidates milestone May 22, 2025
@pullapprove pullapprove bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label May 22, 2025
@thePunderWoman thePunderWoman removed the request for review from atscott May 23, 2025 12:02
@thePunderWoman thePunderWoman added the area: core Issues related to the framework runtime label May 23, 2025
@ngbot ngbot bot added this to the Backlog milestone May 23, 2025
@thePunderWoman thePunderWoman added the action: merge The PR is ready for merge by the caretaker label May 23, 2025
@JeanMeche JeanMeche removed the action: merge The PR is ready for merge by the caretaker label May 23, 2025
@JeanMeche
Copy link
Member Author

Removing the merge badge, TGP returned a handful of breakages.

@atscott atscott force-pushed the revert-5f7f046 branch 3 times, most recently from dbd5a55 to 2aae3ef Compare May 27, 2025 18:41
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label May 27, 2025
@atscott
Copy link
Contributor

atscott commented May 27, 2025

This PR was merged into the repository by commit fe03aa0.

The changes were merged into the following branches: main, 20.0.x

@atscott atscott closed this in fe03aa0 May 27, 2025
atscott pushed a commit that referenced this pull request May 27, 2025
@JeanMeche @atscott
Revert "fix(core): call DestroyRef on destroy callback if view is d…
925a41c 
…estroyed (#58008)" (#61625)

This reverts commit 5f7f046.

PR Close #61625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@JeanMeche @atscott @thePunderWoman @AndrewKushnir
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy