refactor(compiler-cli): remove hardcoded config for unused standalone imports rule enablement #61622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… imports rule enablement The hardcoded config was introduced because suppressing the diagnostic via `extendedDiagnostics` in the TS config was unreliable in google3. This has since been fixed and the workaround is no longer needed.
crisbeto
approved these changes
May 22, 2025
dgp1130
approved these changes
May 22, 2025
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hardcoded config was introduced because suppressing the diagnostic via
extendedDiagnosticsin the TS config was unreliable in google3. This has since been fixed and the workaround is no longer needed.Internal references: b/413098934 and cl/761262603.