Skip to content

fix(animations): implement getPosition in browser animation builder #39983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(animations): implement getPosition in browser animation builder #39983

wants to merge 1 commit into from

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Dec 5, 2020 •
edited
Loading

Accidently closed #28264 re-opening it here.

Forward getPosition to animation_group_player.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

google-cla bot commented Dec 5, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Dec 5, 2020
@pullapprove pullapprove bot requested a review from jelbourn December 5, 2020 00:57
@mhevery mhevery mentioned this pull request Dec 5, 2020
Closed
11 tasks
@cgatian
Copy link

cgatian commented Dec 5, 2020

We have been waiting for this! This is the first contribution from the Hyland team. We are going celebrate when this is merged.

Good job @literalpie

@literalpie
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Dec 5, 2020
@literalpie @mhevery
fix(animations): implement getPosition in browser animation builder
392ec47 
Forward `getPosition` to `animation_group_player`.
@mhevery
Copy link
Contributor Author

mhevery commented Dec 7, 2020

presubmit

@literalpie
Copy link
Contributor

I see that the presubmit check is failing. Is there anything I can do to help?

@mhevery mhevery added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release labels Dec 8, 2020
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Dec 8, 2020
@mhevery
Copy link
Contributor Author

mhevery commented Dec 8, 2020

MERGE_ASSISTANCE: This PR has already been approved in #28264 (and accidently closed) This will be merged without further approval.

@mhevery mhevery closed this in ca08625 Dec 9, 2020
mhevery pushed a commit that referenced this pull request Dec 9, 2020
@literalpie @mhevery
fix(animations): implement getPosition in browser animation builder (#…
5a765f0 
…39983)

Forward `getPosition` to `animation_group_player`.

PR Close #39983
@literalpie
Copy link
Contributor

@mhevery was this unintentionally closed again?

@petebacondarwin
Copy link
Contributor

@literalpie - no it was merged by our tooling which github doesn't understand, so we close the PR directly.

@literalpie
Copy link
Contributor

Cool, thank you!

@JoostK
Copy link
Member

JoostK commented Dec 9, 2020

As a matter of fact this has already been released in 11.0.4 :)

@JoostK JoostK mentioned this pull request Dec 9, 2020
Closed
@JoostK JoostK linked an issue Dec 9, 2020 that may be closed by this pull request
AnimationPlayer.getPosition always returns zero #18891
Closed
@JoostK JoostK mentioned this pull request Dec 9, 2020
Closed
@JoostK JoostK linked an issue Dec 9, 2020 that may be closed by this pull request
AnimationGroupPlayer getPosition() always zero #23785
Closed
zarend pushed a commit to zarend/angular that referenced this pull request Dec 10, 2020
@literalpie @zarend
fix(animations): implement getPosition in browser animation builder (a…
7f8eba3 
…ngular#39983)

Forward `getPosition` to `animation_group_player`.

PR Close angular#39983
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AnimationGroupPlayer getPosition() always zero AnimationPlayer.getPosition always returns zero
5 participants
@mhevery @cgatian @literalpie @petebacondarwin @JoostK
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy