fix(core): remove duplicated noop function (#39761)

cexbrayat · AndrewKushnir · commit 26a133756b56 · 2020-11-19T12:14:14.000-08:00
The codebase currently contains several `noop` functions, and they can end up in the bundle of an application. A recent commit 6fbe219 tipped us off as it introduced several `noop` occurrences in the golden symbol files. After investigating with @petebacondarwin, we decided to remove the duplicated functions. This probably shaves only a few bytes, but this commit removes the duplicated functions, by always using the one in `core/src/utils/noop`. PR Close #39761
diff --git a/packages/compiler/src/render3/view/util.ts b/packages/compiler/src/render3/view/util.ts
@@ -142,8 +142,6 @@ export function getQueryPredicate(
   }
 }
 
-export function noop() {}
-
 export class DefinitionMap {
   values: {key: string, quoted: boolean, value: o.Expression}[] = [];
 
diff --git a/packages/core/src/zone/ng_zone.ts b/packages/core/src/zone/ng_zone.ts
@@ -8,6 +8,7 @@
 
 import {EventEmitter} from '../event_emitter';
 import {global} from '../util/global';
+import {noop} from '../util/noop';
 import {getNativeRequestAnimationFrame} from '../util/raf';
 
 
@@ -224,7 +225,6 @@ export class NgZone {
   }
 }
 
-function noop() {}
 const EMPTY_PAYLOAD = {};
 
 interface NgZonePrivate extends NgZone {
diff --git a/packages/core/test/bundling/forms/bundle.golden_symbols.json b/packages/core/test/bundling/forms/bundle.golden_symbols.json
@@ -1397,9 +1397,6 @@
   {
     "name": "noop"
   },
-  {
-    "name": "noop"
-  },
   {
     "name": "normalizeValidators"
   },
diff --git a/packages/core/test/bundling/router/bundle.golden_symbols.json b/packages/core/test/bundling/router/bundle.golden_symbols.json
@@ -1721,9 +1721,6 @@
   {
     "name": "noop"
   },
-  {
-    "name": "noop"
-  },
   {
     "name": "normalizeQueryParams"
   },
diff --git a/packages/core/test/render3/render_util.ts b/packages/core/test/render3/render_util.ts
@@ -18,6 +18,7 @@ import {TConstants, TNodeType} from '@angular/core/src/render3/interfaces/node';
 import {RComment, RElement, RNode, RText} from '@angular/core/src/render3/interfaces/renderer_dom';
 import {enterView, getLView} from '@angular/core/src/render3/state';
 import {EMPTY_ARRAY} from '@angular/core/src/util/empty';
+import {noop} from '@angular/core/src/util/noop';
 import {stringifyElement} from '@angular/platform-browser/testing/src/browser_util';
 
 import {SWITCH_CHANGE_DETECTOR_REF_FACTORY__POST_R3__ as R3_CHANGE_DETECTOR_REF_FACTORY} from '../../src/change_detection/change_detector_ref';
@@ -85,7 +86,6 @@ export abstract class BaseFixture {
   }
 }
 
-function noop() {}
 /**
  * Fixture for testing template functions in a convenient way.
  *

Original file line number	Diff line number	Diff line change
`@@ -142,8 +142,6 @@ export function getQueryPredicate(`
`142`	`142`	`}`
`143`	`143`	`}`
`144`	`144`
`145`		`-export function noop() {}`
`146`		`-`
`147`	`145`	`export class DefinitionMap {`
`148`	`146`	`values: {key: string, quoted: boolean, value: o.Expression}[] = [];`
`149`	`147`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`
`9`	`9`	`import {EventEmitter} from '../event_emitter';`
`10`	`10`	`import {global} from '../util/global';`
	`11`	`+import {noop} from '../util/noop';`
`11`	`12`	`import {getNativeRequestAnimationFrame} from '../util/raf';`
`12`	`13`
`13`	`14`
`@@ -224,7 +225,6 @@ export class NgZone {`
`224`	`225`	`}`
`225`	`226`	`}`
`226`	`227`
`227`		`-function noop() {}`
`228`	`228`	`const EMPTY_PAYLOAD = {};`
`229`	`229`
`230`	`230`	`interface NgZonePrivate extends NgZone {`
Original file line number	Diff line number	Diff line change
`@@ -1397,9 +1397,6 @@`
`1397`	`1397`	`{`
`1398`	`1398`	`"name": "noop"`
`1399`	`1399`	`},`
`1400`		`- {`
`1401`		`- "name": "noop"`
`1402`		`- },`
`1403`	`1400`	`{`
`1404`	`1401`	`"name": "normalizeValidators"`
`1405`	`1402`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1721,9 +1721,6 @@`
`1721`	`1721`	`{`
`1722`	`1722`	`"name": "noop"`
`1723`	`1723`	`},`
`1724`		`- {`
`1725`		`- "name": "noop"`
`1726`		`- },`
`1727`	`1724`	`{`
`1728`	`1725`	`"name": "normalizeQueryParams"`
`1729`	`1726`	`},`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ import {TConstants, TNodeType} from '@angular/core/src/render3/interfaces/node';`
`18`	`18`	`import {RComment, RElement, RNode, RText} from '@angular/core/src/render3/interfaces/renderer_dom';`
`19`	`19`	`import {enterView, getLView} from '@angular/core/src/render3/state';`
`20`	`20`	`import {EMPTY_ARRAY} from '@angular/core/src/util/empty';`
	`21`	`+import {noop} from '@angular/core/src/util/noop';`
`21`	`22`	`import {stringifyElement} from '@angular/platform-browser/testing/src/browser_util';`
`22`	`23`
`23`	`24`	`import {SWITCH_CHANGE_DETECTOR_REF_FACTORY__POST_R3__ as R3_CHANGE_DETECTOR_REF_FACTORY} from '../../src/change_detection/change_detector_ref';`
`@@ -85,7 +86,6 @@ export abstract class BaseFixture {`
`85`	`86`	`}`
`86`	`87`	`}`
`87`	`88`
`88`		`-function noop() {}`
`89`	`89`	`/**`
`90`	`90`	`* Fixture for testing template functions in a convenient way.`
`91`	`91`	`*`