fix(eslint-plugin): fix placeholder in ban-ts-comment (typescript-eslint#1703)

G-Rath · web-flow · commit 144345c4774c · 2020-03-08T18:07:54.000-07:00
diff --git a/packages/eslint-plugin/src/rules/ban-ts-comment.ts b/packages/eslint-plugin/src/rules/ban-ts-comment.ts
@@ -28,7 +28,7 @@ export default util.createRule<[Options], MessageIds>({
     },
     messages: {
       tsDirectiveComment:
-        'Do not use "// @ts-{directive}" because it alters compilation errors.',
+        'Do not use "// @ts-{{directive}}" because it alters compilation errors.',
     },
     schema: [
       {
diff --git a/packages/eslint-plugin/tests/rules/ban-ts-comment.test.ts b/packages/eslint-plugin/tests/rules/ban-ts-comment.test.ts
@@ -113,7 +113,7 @@ ruleTester.run('ts-nocheck', rule, {
       code: '// @ts-nocheck',
       errors: [
         {
-          data: { directive: 'check' },
+          data: { directive: 'nocheck' },
           messageId: 'tsDirectiveComment',
           line: 1,
           column: 1,
@@ -124,7 +124,7 @@ ruleTester.run('ts-nocheck', rule, {
       code: '// @ts-nocheck: Suppress next line',
       errors: [
         {
-          data: { directive: 'check' },
+          data: { directive: 'nocheck' },
           messageId: 'tsDirectiveComment',
           line: 1,
           column: 1,
@@ -135,7 +135,7 @@ ruleTester.run('ts-nocheck', rule, {
       code: '/////@ts-nocheck: Suppress next line',
       errors: [
         {
-          data: { directive: 'check' },
+          data: { directive: 'nocheck' },
           messageId: 'tsDirectiveComment',
           line: 1,
           column: 1,
@@ -151,7 +151,7 @@ if (false) {
             `,
       errors: [
         {
-          data: { directive: 'check' },
+          data: { directive: 'nocheck' },
           messageId: 'tsDirectiveComment',
           line: 3,
           column: 3,

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ export default util.createRule<[Options], MessageIds>({`
`28`	`28`	`},`
`29`	`29`	`messages: {`
`30`	`30`	`tsDirectiveComment:`
`31`		`- 'Do not use "// @ts-{directive}" because it alters compilation errors.',`
	`31`	`+ 'Do not use "// @ts-{{directive}}" because it alters compilation errors.',`
`32`	`32`	`},`
`33`	`33`	`schema: [`
`34`	`34`	`{`