chore: bump typescript dependency to 3.8 (typescript-eslint#1696)

bradzacher · web-flow · commit 85e1b19fd1cc · 2020-03-08T17:45:06.000-07:00
This is the first step in implementing the 3.8 features.
I wanted to keep each PR small and focused, so this is the minimum required work to get the build passing with 3.8 installed.
diff --git a/package.json b/package.json
@@ -74,9 +74,9 @@
     "ts-jest": "^25.0.0",
     "ts-node": "^8.5.0",
     "tslint": "^5.20.1",
-    "typescript": ">=3.2.1 <3.8.0"
+    "typescript": ">=3.2.1 <3.9.0"
   },
   "resolutions": {
-    "typescript": "^3.7.2"
+    "typescript": "^3.8.3"
   }
 }
diff --git a/packages/parser/tests/lib/__snapshots__/jsx.ts.snap b/packages/parser/tests/lib/__snapshots__/jsx.ts.snap
@@ -651,6 +651,8 @@ Object {
 }
 `;
 
+exports[`JSX useJSXTextNode: false fixtures/member-expression-private.src 1`] = `"Identifier expected."`;
+
 exports[`JSX useJSXTextNode: false fixtures/member-expression-this.src 1`] = `
 Object {
   "$id": 1,
diff --git a/packages/parser/tests/lib/__snapshots__/tsx.ts.snap b/packages/parser/tests/lib/__snapshots__/tsx.ts.snap
@@ -50,6 +50,8 @@ Object {
 }
 `;
 
+exports[`TSX fixtures/generic-jsx-member-expression-private.src 1`] = `"Identifier expected."`;
+
 exports[`TSX fixtures/generic-jsx-opening-element.src 1`] = `
 Object {
   "$id": 1,
diff --git a/packages/shared-fixtures/fixtures/jsx/member-expression-private.src.js b/packages/shared-fixtures/fixtures/jsx/member-expression-private.src.js
@@ -0,0 +1 @@
+<this.#foo/>;
diff --git a/packages/shared-fixtures/fixtures/tsx/generic-jsx-member-expression-private.src.tsx b/packages/shared-fixtures/fixtures/tsx/generic-jsx-member-expression-private.src.tsx
@@ -0,0 +1 @@
+const foo = <this.#foo<string>/>
diff --git a/packages/typescript-estree/src/convert.ts b/packages/typescript-estree/src/convert.ts
@@ -458,6 +458,12 @@ export class Converter {
     let result: TSESTree.JSXMemberExpression | TSESTree.JSXIdentifier;
     switch (node.kind) {
       case SyntaxKind.PropertyAccessExpression:
+        if (node.name.kind === SyntaxKind.PrivateIdentifier) {
+          // This is one of the few times where TS explicitly errors, and doesn't even gracefully handle the syntax.
+          // So we shouldn't ever get into this state to begin with.
+          throw new Error('Non-private identifier expected.');
+        }
+
         result = this.createNode<TSESTree.JSXMemberExpression>(node, {
           type: AST_NODE_TYPES.JSXMemberExpression,
           object: this.convertJSXTagName(node.expression, parent),
@@ -467,12 +473,14 @@ export class Converter {
           ) as TSESTree.JSXIdentifier,
         });
         break;
+
       case SyntaxKind.ThisKeyword:
         result = this.createNode<TSESTree.JSXIdentifier>(node, {
           type: AST_NODE_TYPES.JSXIdentifier,
           name: 'this',
         });
         break;
+
       case SyntaxKind.Identifier:
       default:
         result = this.createNode<TSESTree.JSXIdentifier>(node, {
@@ -1570,6 +1578,9 @@ export class Converter {
 
       case SyntaxKind.ExportDeclaration:
         if (node.exportClause) {
+          if (node.exportClause.kind !== SyntaxKind.NamedExports) {
+            throw new Error('`export * as ns` is not yet supported.');
+          }
           return this.createNode<TSESTree.ExportNamedDeclaration>(node, {
             type: AST_NODE_TYPES.ExportNamedDeclaration,
             source: this.convertChild(node.moduleSpecifier),
diff --git a/packages/typescript-estree/tests/lib/__snapshots__/jsx.ts.snap b/packages/typescript-estree/tests/lib/__snapshots__/jsx.ts.snap
@@ -5289,6 +5289,8 @@ Object {
 }
 `;
 
+exports[`JSX useJSXTextNode: false fixtures/member-expression-private.src 1`] = `"Identifier expected."`;
+
 exports[`JSX useJSXTextNode: false fixtures/member-expression-this.src 1`] = `
 Object {
   "body": Array [
diff --git a/packages/typescript-estree/tests/lib/__snapshots__/semantic-diagnostics-enabled.ts.snap b/packages/typescript-estree/tests/lib/__snapshots__/semantic-diagnostics-enabled.ts.snap
@@ -1555,6 +1555,15 @@ exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" e
 
 exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/jsx/member-expression.src 1`] = `"TEST OUTPUT: No semantic or syntactic issues found"`;
 
+exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/jsx/member-expression-private.src 1`] = `
+Object {
+  "column": 10,
+  "index": 10,
+  "lineNumber": 1,
+  "message": "Identifier expected.",
+}
+`;
+
 exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/jsx/member-expression-this.src 1`] = `"TEST OUTPUT: No semantic or syntactic issues found"`;
 
 exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/jsx/multiple-blank-spaces.src 1`] = `"TEST OUTPUT: No semantic or syntactic issues found"`;
@@ -1627,6 +1636,15 @@ exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" e
 
 exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/tsx/generic-jsx-element.src 1`] = `"TEST OUTPUT: No semantic or syntactic issues found"`;
 
+exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/tsx/generic-jsx-member-expression-private.src 1`] = `
+Object {
+  "column": 22,
+  "index": 22,
+  "lineNumber": 1,
+  "message": "Identifier expected.",
+}
+`;
+
 exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/tsx/generic-jsx-opening-element.src 1`] = `"TEST OUTPUT: No semantic or syntactic issues found"`;
 
 exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/tsx/react-typed-props.src 1`] = `"TEST OUTPUT: No semantic or syntactic issues found"`;
@@ -1689,7 +1707,7 @@ Object {
   "column": 14,
   "index": 31,
   "lineNumber": 2,
-  "message": "'await' expression is only allowed within an async function.",
+  "message": "'await' expressions are only allowed within async functions and at the top levels of modules.",
 }
 `;
 
diff --git a/packages/typescript-estree/tests/lib/__snapshots__/tsx.ts.snap b/packages/typescript-estree/tests/lib/__snapshots__/tsx.ts.snap
@@ -422,6 +422,8 @@ Object {
 }
 `;
 
+exports[`TSX fixtures/generic-jsx-member-expression-private.src 1`] = `"Identifier expected."`;
+
 exports[`TSX fixtures/generic-jsx-opening-element.src 1`] = `
 Object {
   "body": Array [
diff --git a/yarn.lock b/yarn.lock
@@ -8152,10 +8152,10 @@ typedarray@^0.0.6:
   resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
   integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
 
-typescript@*, "typescript@>=3.2.1 <3.8.0", typescript@^3.7.2:
-  version "3.7.5"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.7.5.tgz#0692e21f65fd4108b9330238aac11dd2e177a1ae"
-  integrity sha512-/P5lkRXkWHNAbcJIiHPfRoKqyd7bsyCma1hZNUGfn20qm64T6ZBlrzprymeu918H+mB/0rIg2gGK/BXkhhYgBw==
+typescript@*, "typescript@>=3.2.1 <3.9.0", typescript@^3.8.3:
+  version "3.8.3"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.8.3.tgz#409eb8544ea0335711205869ec458ab109ee1061"
+  integrity sha512-MYlEfn5VrLNsgudQTVJeNaQFUAI7DkhnOjdpAp4T+ku1TfQClewlbSuTVHiA+8skNBgaf02TL/kLOvig4y3G8w==
 
 uglify-js@^3.1.4:
   version "3.6.0"

Original file line number	Diff line number	Diff line change
`@@ -74,9 +74,9 @@`
`74`	`74`	`"ts-jest": "^25.0.0",`
`75`	`75`	`"ts-node": "^8.5.0",`
`76`	`76`	`"tslint": "^5.20.1",`
`77`		`- "typescript": ">=3.2.1 <3.8.0"`
	`77`	`+ "typescript": ">=3.2.1 <3.9.0"`
`78`	`78`	`},`
`79`	`79`	`"resolutions": {`
`80`		`- "typescript": "^3.7.2"`
	`80`	`+ "typescript": "^3.8.3"`
`81`	`81`	`}`
`82`	`82`	`}`
Original file line number	Diff line number	Diff line change
`@@ -651,6 +651,8 @@ Object {`
`651`	`651`	`}`
`652`	`652`	`;
`653`	`653`
	`654`	+exports[`JSX useJSXTextNode: false fixtures/member-expression-private.src 1`] = `"Identifier expected."`;
	`655`	`+`
`654`	`656`	exports[`JSX useJSXTextNode: false fixtures/member-expression-this.src 1`] = `
`655`	`657`	`Object {`
`656`	`658`	`"$id": 1,`
Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,8 @@ Object {`
`50`	`50`	`}`
`51`	`51`	`;
`52`	`52`
	`53`	+exports[`TSX fixtures/generic-jsx-member-expression-private.src 1`] = `"Identifier expected."`;
	`54`	`+`
`53`	`55`	exports[`TSX fixtures/generic-jsx-opening-element.src 1`] = `
`54`	`56`	`Object {`
`55`	`57`	`"$id": 1,`
Original file line number	Diff line number	Diff line change
`@@ -5289,6 +5289,8 @@ Object {`
`5289`	`5289`	`}`
`5290`	`5290`	`;
`5291`	`5291`
	`5292`	+exports[`JSX useJSXTextNode: false fixtures/member-expression-private.src 1`] = `"Identifier expected."`;
	`5293`	`+`
`5292`	`5294`	exports[`JSX useJSXTextNode: false fixtures/member-expression-this.src 1`] = `
`5293`	`5295`	`Object {`
`5294`	`5296`	`"body": Array [`
Original file line number	Diff line number	Diff line change
`@@ -422,6 +422,8 @@ Object {`
`422`	`422`	`}`
`423`	`423`	`;
`424`	`424`
	`425`	+exports[`TSX fixtures/generic-jsx-member-expression-private.src 1`] = `"Identifier expected."`;
	`426`	`+`
`425`	`427`	exports[`TSX fixtures/generic-jsx-opening-element.src 1`] = `
`426`	`428`	`Object {`
`427`	`429`	`"body": Array [`