Do not set the hibernate or datanucleus span service name when disabled #8727

ygree · 2025-04-23T22:12:27Z

What Does This Do

Do not set the hibernate or datanucleus span service name if dd.trace.remove.integration-service-names.enabled is true or the naming scheme version is v1

Motivation

It's currently impossible to disable and results in an unwanted service name hibernate.

Additional Notes

This may have been an oversight, because of the many DatabaseClientDecorator implementations, only Hibernate and Datanucleus were not updated.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMS-15546

pr-commenter · 2025-04-23T22:52:30Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ygree/hibernate-service-name
git_commit_date	1745519613	1745529820
git_commit_sha	`511416f`	`2afb857`
release_version	1.49.0-SNAPSHOT~511416f4ef	1.49.0-SNAPSHOT~2afb85707d

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1745532832	1745532832
ci_job_id	911961227	911961227
ci_pipeline_id	63279759	63279759
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-4i48fg5e-project-304-concurrent-0-dz17ijvi 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-4i48fg5e-project-304-concurrent-0-dz17ijvi 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 6 performance improvements and 6 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:insecure-bank:iast:Debugger	better [-1.760ms; -1.594ms] or [-30.154%; -27.306%]	4.160ms	5.837ms
scenario:startup:insecure-bank:iast:Telemetry	worse [+610.967µs; +966.327µs] or [+7.801%; +12.339%]	8.620ms	7.832ms
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Debugger	better [-1.894ms; -1.630ms] or [-31.595%; -27.185%]	4.233ms	5.995ms
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Telemetry	worse [+469.612µs; +815.263µs] or [+5.771%; +10.018%]	8.780ms	8.138ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Debugger	better [-1.884ms; -1.692ms] or [-31.629%; -28.418%]	4.167ms	5.955ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Telemetry	worse [+692.214µs; +988.210µs] or [+8.828%; +12.603%]	8.681ms	7.841ms
scenario:startup:petclinic:appsec:Debugger	better [-1.960ms; -1.604ms] or [-32.597%; -26.681%]	4.230ms	6.012ms
scenario:startup:petclinic:appsec:Telemetry	worse [+637.582µs; +870.856µs] or [+8.576%; +11.714%]	8.189ms	7.435ms
scenario:startup:petclinic:iast:Debugger	better [-1.791ms; -1.579ms] or [-30.504%; -26.902%]	4.186ms	5.871ms
scenario:startup:petclinic:iast:Telemetry	worse [+646.626µs; +957.024µs] or [+8.180%; +12.107%]	8.706ms	7.905ms
scenario:startup:petclinic:profiling:Debugger	better [-1.822ms; -1.594ms] or [-29.560%; -25.862%]	4.455ms	6.163ms
scenario:startup:petclinic:profiling:Telemetry	worse [+731.746µs; +1157.624µs] or [+9.032%; +14.289%]	9.046ms	8.101ms

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~2afb85707d, baseline=1.49.0-SNAPSHOT~511416f4ef

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068665
Total [baseline] (8.709 s) : 0, 8709102
Agent [candidate] (1.06 s) : 0, 1059671
Total [candidate] (8.682 s) : 0, 8681515
section iast
Agent [baseline] (1.198 s) : 0, 1197607
Total [baseline] (9.21 s) : 0, 9209667
Agent [candidate] (1.186 s) : 0, 1186423
Total [candidate] (9.242 s) : 0, 9242043
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.207 s) : 0, 1206968
Total [baseline] (9.302 s) : 0, 9302465
Agent [candidate] (1.188 s) : 0, 1187980
Total [candidate] (9.224 s) : 0, 9224200
section iast_TELEMETRY_OFF
Agent [baseline] (1.185 s) : 0, 1185001
Total [baseline] (9.233 s) : 0, 9233098
Agent [candidate] (1.192 s) : 0, 1192160
Total [candidate] (9.273 s) : 0, 9273375

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.069 s	-
Agent	iast	1.198 s	128.942 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.207 s	138.303 ms (12.9%)
Agent	iast_TELEMETRY_OFF	1.185 s	116.336 ms (10.9%)
Total	tracing	8.709 s	-
Total	iast	9.21 s	500.566 ms (5.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.302 s	593.363 ms (6.8%)
Total	iast_TELEMETRY_OFF	9.233 s	523.996 ms (6.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.06 s	-
Agent	iast	1.186 s	126.752 ms (12.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.188 s	128.309 ms (12.1%)
Agent	iast_TELEMETRY_OFF	1.192 s	132.489 ms (12.5%)
Total	tracing	8.682 s	-
Total	iast	9.242 s	560.528 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.224 s	542.685 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.273 s	591.86 ms (6.8%)

gantt
    title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~2afb85707d, baseline=1.49.0-SNAPSHOT~511416f4ef

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (728.581 ms) : 0, 728581
BytebuddyAgent [candidate] (722.861 ms) : 0, 722861
GlobalTracer [baseline] (241.323 ms) : 0, 241323
GlobalTracer [candidate] (239.673 ms) : 0, 239673
AppSec [baseline] (55.505 ms) : 0, 55505
AppSec [candidate] (55.907 ms) : 0, 55907
Debugger [baseline] (7.771 ms) : 0, 7771
Debugger [candidate] (8.02 ms) : 0, 8020
Remote Config [baseline] (699.185 µs) : 0, 699
Remote Config [candidate] (687.614 µs) : 0, 688
Telemetry [baseline] (11.295 ms) : 0, 11295
Telemetry [candidate] (9.088 ms) : 0, 9088
section iast
BytebuddyAgent [baseline] (849.598 ms) : 0, 849598
BytebuddyAgent [candidate] (841.315 ms) : 0, 841315
GlobalTracer [baseline] (231.041 ms) : 0, 231041
GlobalTracer [candidate] (229.795 ms) : 0, 229795
AppSec [baseline] (53.137 ms) : 0, 53137
AppSec [candidate] (52.878 ms) : 0, 52878
Debugger [baseline] (5.837 ms) : 0, 5837
Debugger [candidate] (4.16 ms) : 0, 4160
Remote Config [baseline] (579.94 µs) : 0, 580
Remote Config [candidate] (590.249 µs) : 0, 590
Telemetry [baseline] (7.832 ms) : 0, 7832
Telemetry [candidate] (8.62 ms) : 0, 8620
IAST [baseline] (23.714 ms) : 0, 23714
IAST [candidate] (24.184 ms) : 0, 24184
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (855.593 ms) : 0, 855593
BytebuddyAgent [candidate] (841.969 ms) : 0, 841969
GlobalTracer [baseline] (232.734 ms) : 0, 232734
GlobalTracer [candidate] (229.856 ms) : 0, 229856
AppSec [baseline] (52.009 ms) : 0, 52009
AppSec [candidate] (52.841 ms) : 0, 52841
Debugger [baseline] (5.995 ms) : 0, 5995
Debugger [candidate] (4.233 ms) : 0, 4233
Remote Config [baseline] (613.208 µs) : 0, 613
Remote Config [candidate] (606.069 µs) : 0, 606
Telemetry [baseline] (8.138 ms) : 0, 8138
Telemetry [candidate] (8.78 ms) : 0, 8780
IAST [baseline] (25.098 ms) : 0, 25098
IAST [candidate] (23.884 ms) : 0, 23884
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (838.72 ms) : 0, 838720
BytebuddyAgent [candidate] (845.684 ms) : 0, 845684
GlobalTracer [baseline] (230.007 ms) : 0, 230007
GlobalTracer [candidate] (231.312 ms) : 0, 231312
AppSec [baseline] (56.111 ms) : 0, 56111
AppSec [candidate] (54.896 ms) : 0, 54896
Debugger [baseline] (5.955 ms) : 0, 5955
Debugger [candidate] (4.167 ms) : 0, 4167
Remote Config [baseline] (594.717 µs) : 0, 595
Remote Config [candidate] (613.092 µs) : 0, 613
Telemetry [baseline] (7.841 ms) : 0, 7841
Telemetry [candidate] (8.681 ms) : 0, 8681
IAST [baseline] (22.423 ms) : 0, 22423
IAST [candidate] (23.277 ms) : 0, 23277

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~2afb85707d, baseline=1.49.0-SNAPSHOT~511416f4ef

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071036
Total [baseline] (10.537 s) : 0, 10536998
Agent [candidate] (1.065 s) : 0, 1064549
Total [candidate] (10.506 s) : 0, 10505870
section appsec
Agent [baseline] (1.201 s) : 0, 1201336
Total [baseline] (10.771 s) : 0, 10771103
Agent [candidate] (1.198 s) : 0, 1198351
Total [candidate] (10.788 s) : 0, 10787942
section iast
Agent [baseline] (1.189 s) : 0, 1188591
Total [baseline] (10.888 s) : 0, 10887924
Agent [candidate] (1.188 s) : 0, 1188265
Total [candidate] (11.011 s) : 0, 11011495
section profiling
Agent [baseline] (1.315 s) : 0, 1315243
Total [baseline] (10.763 s) : 0, 10763028
Agent [candidate] (1.313 s) : 0, 1313021
Total [candidate] (10.974 s) : 0, 10974497

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.071 s	-
Agent	appsec	1.201 s	130.3 ms (12.2%)
Agent	iast	1.189 s	117.556 ms (11.0%)
Agent	profiling	1.315 s	244.207 ms (22.8%)
Total	tracing	10.537 s	-
Total	appsec	10.771 s	234.105 ms (2.2%)
Total	iast	10.888 s	350.926 ms (3.3%)
Total	profiling	10.763 s	226.03 ms (2.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.065 s	-
Agent	appsec	1.198 s	133.802 ms (12.6%)
Agent	iast	1.188 s	123.717 ms (11.6%)
Agent	profiling	1.313 s	248.472 ms (23.3%)
Total	tracing	10.506 s	-
Total	appsec	10.788 s	282.071 ms (2.7%)
Total	iast	11.011 s	505.625 ms (4.8%)
Total	profiling	10.974 s	468.626 ms (4.5%)

gantt
    title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~2afb85707d, baseline=1.49.0-SNAPSHOT~511416f4ef

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (729.892 ms) : 0, 729892
BytebuddyAgent [candidate] (726.446 ms) : 0, 726446
GlobalTracer [baseline] (243.022 ms) : 0, 243022
GlobalTracer [candidate] (240.953 ms) : 0, 240953
AppSec [baseline] (55.219 ms) : 0, 55219
AppSec [candidate] (55.606 ms) : 0, 55606
Debugger [baseline] (9.322 ms) : 0, 9322
Debugger [candidate] (5.766 ms) : 0, 5766
Remote Config [baseline] (715.815 µs) : 0, 716
Remote Config [candidate] (696.028 µs) : 0, 696
Telemetry [baseline] (9.121 ms) : 0, 9121
Telemetry [candidate] (11.448 ms) : 0, 11448
section appsec
BytebuddyAgent [baseline] (740.169 ms) : 0, 740169
BytebuddyAgent [candidate] (739.038 ms) : 0, 739038
GlobalTracer [baseline] (236.507 ms) : 0, 236507
GlobalTracer [candidate] (236.141 ms) : 0, 236141
AppSec [baseline] (176.1 ms) : 0, 176100
AppSec [candidate] (175.653 ms) : 0, 175653
Debugger [baseline] (6.012 ms) : 0, 6012
Debugger [candidate] (4.23 ms) : 0, 4230
Remote Config [baseline] (632.368 µs) : 0, 632
Remote Config [candidate] (633.069 µs) : 0, 633
Telemetry [baseline] (7.435 ms) : 0, 7435
Telemetry [candidate] (8.189 ms) : 0, 8189
IAST [baseline] (21.722 ms) : 0, 21722
IAST [candidate] (21.841 ms) : 0, 21841
section iast
BytebuddyAgent [baseline] (842.129 ms) : 0, 842129
BytebuddyAgent [candidate] (842.178 ms) : 0, 842178
GlobalTracer [baseline] (230.078 ms) : 0, 230078
GlobalTracer [candidate] (230.168 ms) : 0, 230168
AppSec [baseline] (52.787 ms) : 0, 52787
AppSec [candidate] (52.318 ms) : 0, 52318
Debugger [baseline] (5.871 ms) : 0, 5871
Debugger [candidate] (4.186 ms) : 0, 4186
Remote Config [baseline] (585.522 µs) : 0, 586
Remote Config [candidate] (604.416 µs) : 0, 604
Telemetry [baseline] (7.905 ms) : 0, 7905
Telemetry [candidate] (8.706 ms) : 0, 8706
IAST [baseline] (22.743 ms) : 0, 22743
IAST [candidate] (24.387 ms) : 0, 24387
section profiling
BytebuddyAgent [baseline] (714.918 ms) : 0, 714918
BytebuddyAgent [candidate] (714.318 ms) : 0, 714318
GlobalTracer [baseline] (376.87 ms) : 0, 376870
GlobalTracer [candidate] (377.877 ms) : 0, 377877
AppSec [baseline] (54.372 ms) : 0, 54372
AppSec [candidate] (53.565 ms) : 0, 53565
Debugger [baseline] (6.163 ms) : 0, 6163
Debugger [candidate] (4.455 ms) : 0, 4455
Remote Config [baseline] (648.631 µs) : 0, 649
Remote Config [candidate] (661.692 µs) : 0, 662
Telemetry [baseline] (8.101 ms) : 0, 8101
Telemetry [candidate] (9.046 ms) : 0, 9046
ProfilingAgent [baseline] (103.819 ms) : 0, 103819
ProfilingAgent [candidate] (102.731 ms) : 0, 102731
Profiling [baseline] (103.844 ms) : 0, 103844
Profiling [candidate] (102.756 ms) : 0, 102756

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-04-24T21:42:01	2025-04-24T21:49:47
git_branch	master	ygree/hibernate-service-name
git_commit_date	1745519613	1745529820
git_commit_sha	`511416f`	`2afb857`
release_version	1.49.0-SNAPSHOT~511416f4ef	1.49.0-SNAPSHOT~2afb85707d
start_time	2025-04-24T21:41:46	2025-04-24T21:49:33

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1745531786	1745531786
ci_job_id	911961228	911961228
ci_pipeline_id	63279759	63279759
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-4i48fg5e-project-304-concurrent-1-zcj7cu7h 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-4i48fg5e-project-304-concurrent-1-zcj7cu7h 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~2afb85707d, baseline=1.49.0-SNAPSHOT~511416f4ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (387.188 µs) : 367, 407
.   : milestone, 387,
iast (532.646 µs) : 510, 555
.   : milestone, 533,
iast_FULL (740.965 µs) : 719, 763
.   : milestone, 741,
iast_GLOBAL (577.861 µs) : 555, 601
.   : milestone, 578,
iast_HARDCODED_SECRET_DISABLED (526.772 µs) : 505, 549
.   : milestone, 527,
iast_INACTIVE (470.154 µs) : 447, 493
.   : milestone, 470,
iast_TELEMETRY_OFF (518.882 µs) : 496, 542
.   : milestone, 519,
tracing (464.191 µs) : 443, 485
.   : milestone, 464,
section candidate
no_agent (384.633 µs) : 364, 405
.   : milestone, 385,
iast (512.685 µs) : 491, 534
.   : milestone, 513,
iast_FULL (735.31 µs) : 713, 757
.   : milestone, 735,
iast_GLOBAL (563.941 µs) : 541, 587
.   : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (515.971 µs) : 494, 538
.   : milestone, 516,
iast_INACTIVE (472.964 µs) : 451, 495
.   : milestone, 473,
iast_TELEMETRY_OFF (504.935 µs) : 483, 527
.   : milestone, 505,
tracing (468.667 µs) : 447, 490
.   : milestone, 469,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	387.188 µs [367.411 µs, 406.965 µs]	-
iast	532.646 µs [509.83 µs, 555.462 µs]	145.458 µs (37.6%)
iast_FULL	740.965 µs [718.545 µs, 763.385 µs]	353.777 µs (91.4%)
iast_GLOBAL	577.861 µs [554.8 µs, 600.922 µs]	190.673 µs (49.2%)
iast_HARDCODED_SECRET_DISABLED	526.772 µs [504.914 µs, 548.629 µs]	139.583 µs (36.1%)
iast_INACTIVE	470.154 µs [447.331 µs, 492.978 µs]	82.966 µs (21.4%)
iast_TELEMETRY_OFF	518.882 µs [495.8 µs, 541.964 µs]	131.694 µs (34.0%)
tracing	464.191 µs [443.051 µs, 485.331 µs]	77.003 µs (19.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	384.633 µs [364.182 µs, 405.083 µs]	-
iast	512.685 µs [490.927 µs, 534.443 µs]	128.052 µs (33.3%)
iast_FULL	735.31 µs [713.236 µs, 757.384 µs]	350.677 µs (91.2%)
iast_GLOBAL	563.941 µs [541.226 µs, 586.656 µs]	179.308 µs (46.6%)
iast_HARDCODED_SECRET_DISABLED	515.971 µs [493.863 µs, 538.079 µs]	131.338 µs (34.1%)
iast_INACTIVE	472.964 µs [450.911 µs, 495.017 µs]	88.331 µs (23.0%)
iast_TELEMETRY_OFF	504.935 µs [483.33 µs, 526.54 µs]	120.302 µs (31.3%)
tracing	468.667 µs [446.94 µs, 490.393 µs]	84.034 µs (21.8%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~2afb85707d, baseline=1.49.0-SNAPSHOT~511416f4ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1374
.   : milestone, 1355,
appsec (1.741 ms) : 1717, 1765
.   : milestone, 1741,
appsec_no_iast (1.741 ms) : 1716, 1766
.   : milestone, 1741,
code_origins (1.684 ms) : 1657, 1711
.   : milestone, 1684,
iast (1.514 ms) : 1491, 1538
.   : milestone, 1514,
profiling (1.541 ms) : 1516, 1567
.   : milestone, 1541,
tracing (1.493 ms) : 1468, 1518
.   : milestone, 1493,
section candidate
no_agent (1.375 ms) : 1355, 1394
.   : milestone, 1375,
appsec (1.744 ms) : 1721, 1767
.   : milestone, 1744,
appsec_no_iast (1.725 ms) : 1702, 1749
.   : milestone, 1725,
code_origins (1.709 ms) : 1682, 1736
.   : milestone, 1709,
iast (1.524 ms) : 1499, 1549
.   : milestone, 1524,
profiling (1.525 ms) : 1502, 1548
.   : milestone, 1525,
tracing (1.523 ms) : 1498, 1548
.   : milestone, 1523,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.355 ms [1.335 ms, 1.374 ms]	-
appsec	1.741 ms [1.717 ms, 1.765 ms]	386.535 µs (28.5%)
appsec_no_iast	1.741 ms [1.716 ms, 1.766 ms]	386.262 µs (28.5%)
code_origins	1.684 ms [1.657 ms, 1.711 ms]	329.011 µs (24.3%)
iast	1.514 ms [1.491 ms, 1.538 ms]	159.541 µs (11.8%)
profiling	1.541 ms [1.516 ms, 1.567 ms]	186.583 µs (13.8%)
tracing	1.493 ms [1.468 ms, 1.518 ms]	138.121 µs (10.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.375 ms [1.355 ms, 1.394 ms]	-
appsec	1.744 ms [1.721 ms, 1.767 ms]	368.893 µs (26.8%)
appsec_no_iast	1.725 ms [1.702 ms, 1.749 ms]	350.657 µs (25.5%)
code_origins	1.709 ms [1.682 ms, 1.736 ms]	334.335 µs (24.3%)
iast	1.524 ms [1.499 ms, 1.549 ms]	149.293 µs (10.9%)
profiling	1.525 ms [1.502 ms, 1.548 ms]	150.173 µs (10.9%)
tracing	1.523 ms [1.498 ms, 1.548 ms]	148.231 µs (10.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ygree/hibernate-service-name
git_commit_date	1745519613	1745529820
git_commit_sha	`511416f`	`2afb857`
release_version	1.49.0-SNAPSHOT~511416f4ef	1.49.0-SNAPSHOT~2afb85707d

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1745532401	1745532401
ci_job_id	911961229	911961229
ci_pipeline_id	63279759	63279759
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-hcxq3npz-project-304-concurrent-0-y3aa9w2y 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-hcxq3npz-project-304-concurrent-0-y3aa9w2y 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~2afb85707d, baseline=1.49.0-SNAPSHOT~511416f4ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.421 s) : 15421000, 15421000
.   : milestone, 15421000,
appsec (15.097 s) : 15097000, 15097000
.   : milestone, 15097000,
iast (18.463 s) : 18463000, 18463000
.   : milestone, 18463000,
iast_GLOBAL (18.163 s) : 18163000, 18163000
.   : milestone, 18163000,
profiling (15.113 s) : 15113000, 15113000
.   : milestone, 15113000,
tracing (14.958 s) : 14958000, 14958000
.   : milestone, 14958000,
section candidate
no_agent (15.04 s) : 15040000, 15040000
.   : milestone, 15040000,
appsec (14.845 s) : 14845000, 14845000
.   : milestone, 14845000,
iast (19.091 s) : 19091000, 19091000
.   : milestone, 19091000,
iast_GLOBAL (18.005 s) : 18005000, 18005000
.   : milestone, 18005000,
profiling (15.111 s) : 15111000, 15111000
.   : milestone, 15111000,
tracing (15.242 s) : 15242000, 15242000
.   : milestone, 15242000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.421 s [15.421 s, 15.421 s]	-
appsec	15.097 s [15.097 s, 15.097 s]	-324.0 ms (-2.1%)
iast	18.463 s [18.463 s, 18.463 s]	3.042 s (19.7%)
iast_GLOBAL	18.163 s [18.163 s, 18.163 s]	2.742 s (17.8%)
profiling	15.113 s [15.113 s, 15.113 s]	-308.0 ms (-2.0%)
tracing	14.958 s [14.958 s, 14.958 s]	-463.0 ms (-3.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.04 s [15.04 s, 15.04 s]	-
appsec	14.845 s [14.845 s, 14.845 s]	-195.0 ms (-1.3%)
iast	19.091 s [19.091 s, 19.091 s]	4.051 s (26.9%)
iast_GLOBAL	18.005 s [18.005 s, 18.005 s]	2.965 s (19.7%)
profiling	15.111 s [15.111 s, 15.111 s]	71.0 ms (0.5%)
tracing	15.242 s [15.242 s, 15.242 s]	202.0 ms (1.3%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~2afb85707d, baseline=1.49.0-SNAPSHOT~511416f4ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.373 ms) : 2326, 2419
.   : milestone, 2373,
iast (2.158 ms) : 2099, 2217
.   : milestone, 2158,
iast_GLOBAL (2.186 ms) : 2127, 2245
.   : milestone, 2186,
profiling (1.984 ms) : 1938, 2030
.   : milestone, 1984,
tracing (1.991 ms) : 1946, 2036
.   : milestone, 1991,
section candidate
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.371 ms) : 2325, 2418
.   : milestone, 2371,
iast (2.161 ms) : 2102, 2220
.   : milestone, 2161,
iast_GLOBAL (2.188 ms) : 2129, 2247
.   : milestone, 2188,
profiling (2.002 ms) : 1956, 2049
.   : milestone, 2002,
tracing (1.971 ms) : 1926, 2016
.   : milestone, 1971,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.459 ms, 1.482 ms]	-
appsec	2.373 ms [2.326 ms, 2.419 ms]	902.371 µs (61.4%)
iast	2.158 ms [2.099 ms, 2.217 ms]	688.004 µs (46.8%)
iast_GLOBAL	2.186 ms [2.127 ms, 2.245 ms]	715.915 µs (48.7%)
profiling	1.984 ms [1.938 ms, 2.03 ms]	514.144 µs (35.0%)
tracing	1.991 ms [1.946 ms, 2.036 ms]	520.899 µs (35.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.468 ms [1.456 ms, 1.479 ms]	-
appsec	2.371 ms [2.325 ms, 2.418 ms]	903.661 µs (61.6%)
iast	2.161 ms [2.102 ms, 2.22 ms]	693.313 µs (47.2%)
iast_GLOBAL	2.188 ms [2.129 ms, 2.247 ms]	720.197 µs (49.1%)
profiling	2.002 ms [1.956 ms, 2.049 ms]	534.768 µs (36.4%)
tracing	1.971 ms [1.926 ms, 2.016 ms]	503.327 µs (34.3%)

…e.remove.integration-service-names.enabled` is `true` or the naming scheme version is `v1`

deejgregor · 2025-04-29T23:19:35Z

Thanks, @amarziali!

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `3.22.2` -> `3.22.3` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.28.0` -> `2.28.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.48.2` -> `1.49.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | --- ### Release Notes <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.22.3`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3223-2025-05-06) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.56.3 ([844f4fa](googleapis/java-logging@844f4fa)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.46.3 ([#1801](googleapis/java-logging#1801)) ([d7aa7bc](googleapis/java-logging@d7aa7bc)) - Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0 ([#1803](googleapis/java-logging#1803)) ([5967ffe](googleapis/java-logging@5967ffe)) - Update googleapis/sdk-platform-java action to v2.57.0 ([#1804](googleapis/java-logging#1804)) ([e9a27ec](googleapis/java-logging@e9a27ec)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.28.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2281-2025-05-06) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0 ([#1841](googleapis/java-datastore#1841)) ([ac393e6](googleapis/java-datastore@ac393e6)) - Update googleapis/sdk-platform-java action to v2.57.0 ([#1842](googleapis/java-datastore#1842)) ([0745906](googleapis/java-datastore@0745906)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.49.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.49.0): 1.49.0 ### Components #### Configuration at Runtime - ✨ Add process tags as list to remote config payload ([#8705](DataDog/dd-trace-java#8705) - [@amarziali](https://github.com/amarziali)) #### Continuous Integration Visibility - 🐛 Add span propagation for Pekko scheduled tasks ([#8765](DataDog/dd-trace-java#8765) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Update test.retry_reason to use full name of the feature ([#8689](DataDog/dd-trace-java#8689) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🧹 Remove unused TestEventsHandler methods ([#8674](DataDog/dd-trace-java#8674) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) #### Dynamic Instrumentation - 🐛 Fix exclude identifiers normalization ([#8742](DataDog/dd-trace-java#8742) - [@jpbempel](https://github.com/jpbempel)) - ✨ Make source file tracking asynchronous ([#8684](DataDog/dd-trace-java#8684) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add scope filtering for symbol extraction ([#8676](DataDog/dd-trace-java#8676) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add support for [@key](https://github.com/key) and [@value](https://github.com/value) for Map filtering ([#8669](DataDog/dd-trace-java#8669) - [@jpbempel](https://github.com/jpbempel)) #### Library Injection - ✨ Add system property to force injection of the tracing library even though multiple javaagents have been detected ([#8697](DataDog/dd-trace-java#8697) - [@cecile75](https://github.com/cecile75)) #### Metrics - ✨ Allow dogstatsd port to be configurable with DD_DOGSTATSD_PORT ([#8693](DataDog/dd-trace-java#8693) - [@randomanderson](https://github.com/randomanderson)) #### Profiling - ✨ Bump ddprof-java to 1.25.1 ([#8750](DataDog/dd-trace-java#8750) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Remove cleanup-on-shutdown for temporary files ([#8746](DataDog/dd-trace-java#8746) - [@jbachorik](https://github.com/jbachorik)) - ✨⚡ Replace a regex-based SMAP parser with a hand-crafted one ([#8730](DataDog/dd-trace-java#8730) - [@jbachorik](https://github.com/jbachorik)) - ✨ Improve error reporting on profiler startup ([#8714](DataDog/dd-trace-java#8714) - [@jbachorik](https://github.com/jbachorik)) - ✨ Exclude ProxyLeakTask exception from exception profiling ([#8666](DataDog/dd-trace-java#8666) - [@jbachorik](https://github.com/jbachorik)) - ✨ Use jvmstat for JDKs 9+ programmatically ([#8641](DataDog/dd-trace-java#8641) - [@MattAlp](https://github.com/MattAlp)) #### Telemetry - ✨ Allow dogstatsd port to be configurable with DD_DOGSTATSD_PORT ([#8693](DataDog/dd-trace-java#8693) - [@randomanderson](https://github.com/randomanderson)) - 🐛 Fix appsec.waf.requests telemetry metric ([#8644](DataDog/dd-trace-java#8644) - [@jandro996](https://github.com/jandro996)) #### Tracer core - ✨ Exclude jackson afterburner dynamic classes from instrumentation ([#8747](DataDog/dd-trace-java#8747) - [@amarziali](https://github.com/amarziali)) - ✨ Introduce Java 8 bytecode bridge for instrumentation API ([#8736](DataDog/dd-trace-java#8736) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ⚡🧹 Use byte-buddy classes optimized for Java8+ ([#8735](DataDog/dd-trace-java#8735) - [@mcculls](https://github.com/mcculls)) - 🐛 Do not set the hibernate or datanucleus span service name when disabled ([#8727](DataDog/dd-trace-java#8727) - [@ygree](https://github.com/ygree)) - ✨ Update bytebuddy and ASM to support JDK 24 ([#8720](DataDog/dd-trace-java#8720) - [@sarahchen6](https://github.com/sarahchen6)) - 🐛 Turn off JDK socket support by default ([#8715](DataDog/dd-trace-java#8715) - [@mcculls](https://github.com/mcculls)) - 🐛 Log warning when trace buffer overflow occurs ([#8712](DataDog/dd-trace-java#8712) - [@ygree](https://github.com/ygree)) - ✨🧪 Introducing an internal integration name ([#8708](DataDog/dd-trace-java#8708) - [@amarziali](https://github.com/amarziali)) - ✨ Add process tags to client stats payload ([#8704](DataDog/dd-trace-java#8704) - [@amarziali](https://github.com/amarziali)) - ✨ Collect process tags for tracing ([#8698](DataDog/dd-trace-java#8698) - [@amarziali](https://github.com/amarziali)) - ✨ Stable Config file: target system properties in process_arguments and support template variables in YamlParser ([#8690](DataDog/dd-trace-java#8690) - [@mtoffl01](https://github.com/mtoffl01)) - ✨⚡ Use prefix trie for proxy ignores ([#8678](DataDog/dd-trace-java#8678) - [@amarziali](https://github.com/amarziali)) - ✨ Allow agent to be automatically injected when running aside Log4J patch agent ([#8648](DataDog/dd-trace-java#8648) - [@paullegranddc](https://github.com/paullegranddc)) - ✨ Use jvmstat for JDKs 9+ programmatically ([#8641](DataDog/dd-trace-java#8641) - [@MattAlp](https://github.com/MattAlp)) #### Tracer internal logging - 🐛 Delete print line ([#8686](DataDog/dd-trace-java#8686) - [@sarahchen6](https://github.com/sarahchen6)) ### Instrumentations #### Akka instrumentation - 🐛 Handle reentrant scope cleanup in Akka/Pekko actor instrumentations ([#8722](DataDog/dd-trace-java#8722) - [@mcculls](https://github.com/mcculls)) #### Apache Spark instrumentation - ✨ Use OpenLineage root parent information to generate trace id ([#8726](DataDog/dd-trace-java#8726) - [@mobuchowski](https://github.com/mobuchowski)) - ✨ Spark job cancellation no longer marks application as failed ([#8701](DataDog/dd-trace-java#8701) - [@paul-laffon-dd](https://github.com/paul-laffon-dd)) #### JDBC instrumentation - 💡 Add support for sybase tds jdbc driver ([#8764](DataDog/dd-trace-java#8764) - [@amarziali](https://github.com/amarziali)) #### Kotlin instrumentation - 🐛 Take defensive copy of parent scope stack when closing nested coroutines ([#8749](DataDog/dd-trace-java#8749) - [@mcculls](https://github.com/mcculls)) #### Reactor instrumentation - ✨⚡ Do not inspect reactor context when not needed ([#8745](DataDog/dd-trace-java#8745) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 795f347ae34d056efc1194c2f606cee7bca1beea

ygree added type: bug comp: core Tracer core labels Apr 23, 2025

ygree added this to the 1.49.0 milestone Apr 23, 2025

ygree self-assigned this Apr 23, 2025

ygree requested a review from a team as a code owner April 23, 2025 22:12

ygree requested a review from amarziali April 23, 2025 22:12

ygree enabled auto-merge (squash) April 23, 2025 23:03

Do not set the hibernate or datanucleus span service name if `dd.trac…

2afb857

…e.remove.integration-service-names.enabled` is `true` or the naming scheme version is `v1`

ygree force-pushed the ygree/hibernate-service-name branch from e5676fe to 2afb857 Compare April 24, 2025 21:25

amarziali approved these changes Apr 28, 2025

View reviewed changes

ygree merged commit d306e15 into master Apr 28, 2025
459 checks passed

ygree deleted the ygree/hibernate-service-name branch April 28, 2025 08:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Do not set the hibernate or datanucleus span service name when disabled #8727

Do not set the hibernate or datanucleus span service name when disabled #8727

Uh oh!

ygree commented Apr 23, 2025 •

edited by jira bot

Loading

Uh oh!

pr-commenter bot commented Apr 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

deejgregor commented Apr 29, 2025

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Do not set the hibernate or datanucleus span service name when disabled #8727

Do not set the hibernate or datanucleus span service name when disabled #8727

Uh oh!

Conversation

ygree commented Apr 23, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

deejgregor commented Apr 29, 2025

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

ygree commented Apr 23, 2025 •

edited by jira bot

Loading

pr-commenter bot commented Apr 23, 2025 •

edited

Loading