This repository was archived by the owner on Mar 12, 2025. It is now read-only.
fix: Generate gRPC files for long-running operations #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Ah, actually, it looks like there are some more import weirdnesses than I expected. The committed |
|
I'm thinking of leaving the grpc file to its generated name # operations_grpc_pb2.py
from google.longrunning.operations_proto_pb2 import *
from google.longrunning.operations_pb2_grpc import *This would ensure that all users who currently import either The only mild downside is the naming mess. |
* Replaced operations_grpc_pb2 with compatibility file * Removed renaming of newly-genrated operations_pb2_grpc file in noxfile.py
…n-api-common-protos into lro-generate-grpc
|
I think the naming mess is kind of unavoidable at this point. 🤷 I'll ping some folks to see if they have more historical context on the LRO directory. Thank you for the PR! |
busunkim96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
busunkim96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
busunkim96
approved these changes
Dec 22, 2020
busunkim96
changed the title
busunkim96
changed the title
busunkim96
added
automerge
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 27, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.53.0dev1](https://www.github.com/googleapis/python-api-common-protos/compare/v1.52.0...v1.53.0dev1) (2021-01-27) ### Features * add `google.api.ResourceDescriptor.Style` ([4ce679c](https://www.github.com/googleapis/python-api-common-protos/commit/4ce679cd49771946bf781108e92e07cdf04a61eb)) * require python >=3.6 and ([#31](https://www.github.com/googleapis/python-api-common-protos/issues/31)) ([4ce679c](https://www.github.com/googleapis/python-api-common-protos/commit/4ce679cd49771946bf781108e92e07cdf04a61eb)) ### Bug Fixes * add `create_key` to FieldDescriptors ([4ce679c](https://www.github.com/googleapis/python-api-common-protos/commit/4ce679cd49771946bf781108e92e07cdf04a61eb)) * Generate gRPC files for long-running operations ([#13](https://www.github.com/googleapis/python-api-common-protos/issues/13)) ([a9ce288](https://www.github.com/googleapis/python-api-common-protos/commit/a9ce28840ddfec712da5b296f43e6c3131840db4)) ### Documentation * add link to PyPI ([#10](https://www.github.com/googleapis/python-api-common-protos/issues/10)) ([3f79402](https://www.github.com/googleapis/python-api-common-protos/commit/3f7940226b0e22aef31b82c8dc2196aa25b48a3f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12 🦕
(My automatic whitespace formatter removed some trailing whitespace, is this an issue?)
Note that I'm not entirely sure how to work with synthtool, and so I couldn't figure out how to get the license header and formatting fixed before committing the files generated by
nox -s generate_protos. Someone else is going to have to do that part for me 🙂 Still, the generated grpc file looks good.