Content-Length: 392602 | pFad | https://github.com/typescript-eslint/typescript-eslint/pull/10993

A9 fix(eslint-plugin): [use-unknown-in-catch-callback-variable] remove fixable property by mho22 · Pull Request #10993 · typescript-eslint/typescript-eslint · GitHub
Skip to content

fix(eslint-plugin): [use-unknown-in-catch-callback-variable] remove fixable property #10993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 27, 2025
Merged

fix(eslint-plugin): [use-unknown-in-catch-callback-variable] remove fixable property #10993

merged 4 commits into from
Mar 27, 2025

Conversation

mho22
Copy link
Contributor

@mho22 mho22 commented Mar 24, 2025

PR Checklist

Overview

Rule use-unknown-in-catch-callback-variable has fixable: 'code' and hasSuggestions: true properties in meta.

But each fix is located in a suggest property. Making fixable : 'code' useless.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @mho22!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Mar 24, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a9a3bf1
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67e254fd8107ce000821db81
😎 Deploy Preview https://deploy-preview-10993--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 24, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit a9a3bf1.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 6s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-25 07:15:51 UTC

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Mar 24, 2025
@mho22 mho22 changed the title fix(eslint-plugin): [use-unknown-in-catch-callback-variable] remove fixable property fix(eslint-plugin): [use-unknown-in-catch-callback-variable] remove fixable property Mar 24, 2025
@mho22
Copy link
Contributor Author

mho22 commented Mar 24, 2025 •
edited
Loading

@JoshuaKGoldberg I guess the failed check is related to issue #10992.

@codecov Codecov
Copy link

codecov bot commented Mar 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (3241e46) to head (a9a3bf1).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10993   +/-   ##
=======================================
  Coverage   88.02%   88.02%           
=======================================
  Files         470      470           
  Lines       16790    16790           
  Branches     4742     4742           
=======================================
  Hits        14780    14780           
  Misses       1664     1664           
  Partials      346      346
Flag Coverage Δ
unittest 88.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/rules/use-unknown-in-catch-callback-variable.ts 97.53% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 58d7f40 into typescript-eslint:main Mar 27, 2025
56 of 57 checks passed
@mho22 mho22 deleted the fix-use-unknown-in-catch-callback-variable branch March 27, 2025 15:52
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 1, 2025
@renovate
Update typescript-eslint monorepo to v8.29.0
341480a 
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.27.0 | 8.29.0 |
| npm        | @typescript-eslint/parser        | 8.27.0 | 8.29.0 |


## [v8.29.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8290-2025-03-31)

##### 🚀 Features

-   **eslint-plugin:** \[prefer-nullish-coalescing] create `ignoreIfStatements` option ([#11000](typescript-eslint/typescript-eslint#11000))

##### 🩹 Fixes

-   **eslint-plugin:** \[no-array-constructor] remove optional chaining exemption ([#10963](typescript-eslint/typescript-eslint#10963))
-   **eslint-plugin:** support arbitrary extensions in definition files ([#10957](typescript-eslint/typescript-eslint#10957))
-   **eslint-plugin:** \[prefer-for-of] fix false positive when using erasable type syntax within update expressions ([#10981](typescript-eslint/typescript-eslint#10981))
-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] remove fixable property ([#10993](typescript-eslint/typescript-eslint#10993))
-   **eslint-plugin:** \[no-unnecessary-condition] don't report on unnecessary optional array index access when `noUncheckedIndexedAccess` is enabled ([#10961](typescript-eslint/typescript-eslint#10961))

##### ❤️ Thank You

-   Dima Barabash [@dbarabashh](https://github.com/dbarabashh)
-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)
-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)
-   Ronen Amiel
-   Yannick Decat [@mho22](https://github.com/mho22)
-   zyoshoka [@zyoshoka](https://github.com/zyoshoka)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.


## [v8.28.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8280-2025-03-24)

##### 🚀 Features

-   **eslint-plugin:** \[prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs ([#10861](typescript-eslint/typescript-eslint#10861))

##### 🩹 Fixes

-   **eslint-plugin:** \[no-unsafe-function-type] remove fixable property ([#10986](typescript-eslint/typescript-eslint#10986))

##### ❤️ Thank You

-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)
-   Yannick Decat [@mho22](https://github.com/mho22)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 1, 2025
@renovate
Update typescript-eslint monorepo to v8.29.0
74b4b8f 
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.27.0 | 8.29.0 |
| npm        | @typescript-eslint/parser        | 8.27.0 | 8.29.0 |


## [v8.29.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8290-2025-03-31)

##### 🚀 Features

-   **eslint-plugin:** \[prefer-nullish-coalescing] create `ignoreIfStatements` option ([#11000](typescript-eslint/typescript-eslint#11000))

##### 🩹 Fixes

-   **eslint-plugin:** \[no-array-constructor] remove optional chaining exemption ([#10963](typescript-eslint/typescript-eslint#10963))
-   **eslint-plugin:** support arbitrary extensions in definition files ([#10957](typescript-eslint/typescript-eslint#10957))
-   **eslint-plugin:** \[prefer-for-of] fix false positive when using erasable type syntax within update expressions ([#10981](typescript-eslint/typescript-eslint#10981))
-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] remove fixable property ([#10993](typescript-eslint/typescript-eslint#10993))
-   **eslint-plugin:** \[no-unnecessary-condition] don't report on unnecessary optional array index access when `noUncheckedIndexedAccess` is enabled ([#10961](typescript-eslint/typescript-eslint#10961))

##### ❤️ Thank You

-   Dima Barabash [@dbarabashh](https://github.com/dbarabashh)
-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)
-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)
-   Ronen Amiel
-   Yannick Decat [@mho22](https://github.com/mho22)
-   zyoshoka [@zyoshoka](https://github.com/zyoshoka)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.


## [v8.28.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8280-2025-03-24)

##### 🚀 Features

-   **eslint-plugin:** \[prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs ([#10861](typescript-eslint/typescript-eslint#10861))

##### 🩹 Fixes

-   **eslint-plugin:** \[no-unsafe-function-type] remove fixable property ([#10986](typescript-eslint/typescript-eslint#10986))

##### ❤️ Thank You

-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)
-   Yannick Decat [@mho22](https://github.com/mho22)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [use-unknown-in-catch-callback-variable] shouldn't have fixable property
3 participants
@mho22 @JoshuaKGoldberg @kirkwaiblinger








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/typescript-eslint/typescript-eslint/pull/10993

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy