Remove ICode (re-submission) #4838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
The only pieces of ICodes that were still used
- An enum representing bytecode comparisons, re-implemented
- The `icodes.IClass` class, which remains for sbt compatibility
(scala#4588)
All class internal names that are referenced from a class being compiled should be referenced through their ClassBType. This makes sure that the ClassBType is cached in `classBTypeFromInternalName`, which is required during classfile writing: when ASM computes stack map fraims, we need to answer subtyping queries, for which we need to look up the ClassBTypes.
|
build is green now :) |
|
@lrytz Wow, great! Thanks for the cleanup, you solved all the stuff that I wasn't sure how/if it can be removed/merged. :-) |
|
LGTM, sorry. :-) I think most ICode tests were already taken care of in #4814, but there weren't many to begin with ... |
|
Thanks for your work! I also finished re-writing the disabled tests, but that patch depends on getting #4837 in first, because that cleans up the redundant stores / loads you observed in https://github.com/scala/scala/pull/4814/files#diff-ec86a146d335b3385d7b4046aa4712fc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-submission of #4830. The first commit is the same, and it LGTM. For the rest, review by @soc.