Content-Length: 375389 | pFad | https://github.com/kubernetes/kubernetes/pull/131979#event-17997627077

DF Gradute ResilientWatchCacheInitialization to GA by serathius · Pull Request #131979 · kubernetes/kubernetes · GitHub
Skip to content

Gradute ResilientWatchCacheInitialization to GA #131979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Gradute ResilientWatchCacheInitialization to GA #131979

merged 1 commit into from
Jun 5, 2025
+8 −0

Conversation

serathius
Copy link
Contributor

/kind feature

Graduate ResilientWatchCacheInitialization to GA

/cc @wojtek-t @deads2k

Promoting as this feature has been proposed in kubernetes/enhancements#4568 (comment)

@k8s-ci-robot k8s-ci-robot requested a review from deads2k May 27, 2025 11:22
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t May 27, 2025 11:22
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 27, 2025
@seans3
Copy link
Contributor

seans3 commented May 27, 2025

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 27, 2025
@wojtek-t
Copy link
Member

@serathius - two comments:

  1. I think we should update the KEP first - it's fine to GA only part of it, but we should reflect that in the KEP
  2. the test failures are related - we need to switch-on emulation in the place where we try to set FG to false

@wojtek-t wojtek-t self-assigned this May 28, 2025
@serathius serathius force-pushed the watchcache-initialization-ga branch from 70679d1 to 741d0e2 Compare May 28, 2025 09:22
@serathius
Copy link
Contributor Author

I think we should update the KEP first - it's fine to GA only part of it, but we should reflect that in the KEP

Ok, I was not sure what part of KEP to update as it's a combination of two features.

@serathius
Copy link
Contributor Author

Looks like flake
image

@serathius
Copy link
Contributor Author

/retest

@wojtek-t
Copy link
Member

This looks fine - I will tag once the KEP part merges.

@serathius serathius mentioned this pull request Jun 4, 2025
Merged
@serathius
Copy link
Contributor Author

kubernetes/enhancements#5350 was merged. Ping @wojtek-t

@wojtek-t
Copy link
Member

wojtek-t commented Jun 5, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b57ad33c7d71ca5d77ac465ecc0f186050bd6e37

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7f50c56 into kubernetes:master Jun 5, 2025
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
4 participants
@serathius @seans3 @wojtek-t @k8s-ci-robot








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/kubernetes/kubernetes/pull/131979#event-17997627077

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy