Content-Length: 302355 | pFad | https://github.com/googleapis/python-api-core/pull/224

F5 chore: update Noxfile and fix codeblock typo by dandhlee · Pull Request #224 · googleapis/python-api-core · GitHub
Skip to content

chore: update Noxfile and fix codeblock typo #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Conversation

dandhlee
Copy link
Contributor

@dandhlee dandhlee commented Jul 6, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Until 219 is resolved, manually updating the Noxfile so that it's working and doesn't produce outdated YAMLs by using Sphinx 1.5.5 on the docfx Nox job.

Also fixing a minor typo 🤖, I'll manually update the docs so that there is no need for another release (and not get in the way of #212)

Fixes #219 🦕

@dandhlee dandhlee requested a review from a team as a code owner July 6, 2021 22:22
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 6, 2021
@dandhlee
Copy link
Contributor Author

dandhlee commented Jul 6, 2021

It seems that OwlBot is active in this repo, safe to close #219 with this PR.

@tseaver
Copy link
Contributor

tseaver commented Jul 7, 2021

@dandhlee

It seems that OwlBot is active in this repo, safe to close #219 with this PR.

FWIW, noxfile.py is excluded from autogen: Owlbot was just applying nox -e black.

@tseaver tseaver merged commit 877fabc into master Jul 7, 2021
@tseaver tseaver deleted the update_noxfile branch July 7, 2021 15:40
@dandhlee
Copy link
Contributor Author

dandhlee commented Jul 7, 2021

Ah, gotcha. Thanks for that note, I'll reopen the issue.

tseaver added a commit to googleapis/python-cloud-core that referenced this pull request Jul 27, 2021
Works around recent changes to the Kokoro 'docs-presubmt' configuration.

See: googleapis/python-api-core#224
tseaver added a commit to googleapis/python-cloud-core that referenced this pull request Jul 27, 2021
Works around recent changes to the Kokoro 'docs-presubmt' configuration.

See: googleapis/python-api-core#224

Also, pin sphinx version (`docs` / `docfx`) and use 'gcp-sphinx-docfx-yaml' (`docfx`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Noxfile is not updated with Sphinx version pin
2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/googleapis/python-api-core/pull/224

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy