Content-Length: 280873 | pFad | https://github.com/googleapis/python-aiplatform/pull/5162

42 chore(aiplatform): Change command parameter type to Optional[Sequence[str]] in CustomContainerTrainingJob by haru-256 · Pull Request #5162 · googleapis/python-aiplatform · GitHub
Skip to content

chore(aiplatform): Change command parameter type to Optional[Sequence[str]] in CustomContainerTrainingJob #5162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

chore(aiplatform): Change command parameter type to Optional[Sequence[str]] in CustomContainerTrainingJob #5162

wants to merge 2 commits into from

Conversation

haru-256
Copy link
Contributor

@haru-256 haru-256 commented Apr 10, 2025 •
edited
Loading

Checked the followings.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Get the necessary approvals
  • Once the last commit on the PR has been approved, add the "ready to pull" label to the Pull Request

Fixes #5161

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Apr 10, 2025
@sararob sararob added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2025
@sararob sararob added the ready to pull Ready to be merged into the codebase. label Apr 14, 2025
copybara-service bot pushed a commit that referenced this pull request Apr 14, 2025
@haru-256 @copybara-github
chore: Change command parameter type to Optional[Sequence[str]] in Cu…
418607a 
…stomContainerTrainingJob

COPYBARA_INTEGRATE_REVIEW=#5162 from haru-256:chore/fix-type-error 3628505
PiperOrigin-RevId: 747533313
@sararob
Copy link
Contributor

sararob commented Apr 14, 2025

Thanks for your contribution! It was added in 418607a, closing this PR.

@sararob sararob closed this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sararob sararob sararob approved these changes

Assignees
No one assigned
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. ready to pull Ready to be merged into the codebase. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type annotation of command argument in CustomContainerTrainingJob
3 participants
@haru-256 @sararob @yoshi-kokoro








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/googleapis/python-aiplatform/pull/5162

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy