Content-Length: 375630 | pFad | https://github.com/googleapis/google-cloud-python/pull/7808

F2 Tasks: Add smoke test and correct docs/index.rst. by busunkim96 · Pull Request #7808 · googleapis/google-cloud-python · GitHub
Skip to content

Tasks: Add smoke test and correct docs/index.rst. #7808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 29, 2019
Merged

Tasks: Add smoke test and correct docs/index.rst. #7808

merged 6 commits into from
Apr 29, 2019

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Apr 26, 2019 •
edited
Loading

In preparation for Tasks v2 GA.

@busunkim96 busunkim96 requested a review from plamut April 26, 2019 16:52
@busunkim96 busunkim96 requested a review from crwilcox as a code owner April 26, 2019 16:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2019
@busunkim96 busunkim96 changed the title Correct version numbers in docs/index.rst. Tasks: Correct version numbers in docs/index.rst. Apr 26, 2019
@busunkim96 busunkim96 added the api: cloudtasks Issues related to the Cloud Tasks API. label Apr 26, 2019
@busunkim96 busunkim96 changed the title Tasks: Correct version numbers in docs/index.rst. Tasks: Add smoke test and correct docs/index.rst. Apr 26, 2019
plamut
plamut reviewed Apr 29, 2019
View reviewed changes
@plamut
Copy link
Contributor

plamut commented Apr 29, 2019

@busunkim96 How can this be verified, what is the expected result?

I am probably not the best person to review this, as I am not familiar with Tasks, and also need to prioritize PubSub, sorry.

@plamut @busunkim96
Update tasks/tests/system/gapic/v2/test_system_tasks_v2.py
bf30643 
Co-Authored-By: busunkim96 <8822365+busunkim96@users.noreply.github.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 29, 2019
@busunkim96 busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 29, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

tseaver
tseaver reviewed Apr 29, 2019
View reviewed changes
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 29, 2019
@busunkim96 busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 29, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@busunkim96 busunkim96 requested a review from tseaver April 29, 2019 20:44
@busunkim96 busunkim96 merged commit 85e8012 into master Apr 29, 2019
@busunkim96 busunkim96 deleted the busunkim96-patch-6 branch April 29, 2019 20:58
parthea pushed a commit that referenced this pull request Sep 22, 2023
@busunkim96
Tasks: Add smoke test and correct docs/index.rst. (#7808)
b753c79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut left review comments

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: cloudtasks Issues related to the Cloud Tasks API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@busunkim96 @plamut @googlebot @tseaver








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/googleapis/google-cloud-python/pull/7808

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy