Prevent CPU spike in task supervisor when heartbeat timeout exceeded #51023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes apache#50507 When the task supervisor's heartbeat timeout is exceeded, the `max_wait_time` calculation can become 0 or negative, causing `selector.select(timeout=0)` to run in a tight non-blocking loop that consumes 100% CPU as explained in the GitHub issue. Add minimum timeout of 0.01s in `_service_subprocess` to prevent this issue while maintaining responsive task monitoring. **Root Cause:** The issue occurs in the `_monitor_subprocess` method when: 1. `last_heartbeat_ago` becomes very large e.g., 100+ seconds due to bugs like network issues or due to bugs like apache#50500 2. The calculation `HEARTBEAT_TIMEOUT - last_heartbeat_ago * 0.75` becomes negative 3. `max(0, negative_value)` results in 0 4. `selector.select(timeout=0)` runs in a non-blocking tight loop
2 tasks
kaxil
added
the
backport-to-v3-0-test
kaxil
commented
May 24, 2025
potiuk
approved these changes
May 24, 2025
shahar1
approved these changes
May 24, 2025
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
May 25, 2025
…ut exceeded (apache#51023) (cherry picked from commit beb7b62) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
github-actions bot
pushed a commit
to guan404ming/airflow
that referenced
this pull request
May 25, 2025
…ut exceeded (apache#51023) (cherry picked from commit beb7b62) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
This was referenced May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #50507
When the task supervisor's heartbeat timeout is exceeded, the
max_wait_timecalculation can become 0 or negative, causingselector.select(timeout=0)to run in a tight non-blocking loop that consumes 100% CPU as explained in the GitHub issue.Add minimum timeout of 0.01s in
_service_subprocessto prevent this issue while maintaining responsive task monitoring.Root Cause:
The issue occurs in the
_monitor_subprocessmethod when:last_heartbeat_agobecomes very large e.g., 100+ seconds due to bugs like network issues or due to bugs like The task supervisor continues running indefinitely, even after the associated task process has completed #50500HEARTBEAT_TIMEOUT - last_heartbeat_ago * 0.75becomes negativemax(0, negative_value)results in 0selector.select(timeout=0)runs in a non-blocking tight loop^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.