Content-Length: 369944 | pFad | https://github.com/apache/airflow/pull/50875

CB Do not run FAB pre-commits in release branches by potiuk · Pull Request #50875 · apache/airflow · GitHub
Skip to content

Do not run FAB pre-commits in release branches #50875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented May 21, 2025

The openapi generation scripts were run together for FAB and main openapi from core - however we do not want to re-run those scripts at all in non-main branch - i.e. branch we prepare providers from.

This PR splits the openapi script and removes all fab pre-commits from running in non-main branch.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk potiuk added the backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch label May 21, 2025
@potiuk potiuk added this to the Airflow 3.0.2 milestone May 21, 2025
The openapi generation scripts were run together for FAB and main
openapi from core - however we do not want to re-run those scripts at
all in non-main branch - i.e. branch we prepare providers from.

This PR splits the openapi script and removes all fab pre-commits from
running in non-main branch.
@potiuk potiuk force-pushed the split-openapi-generating-scripts branch from 04cdda2 to e354403 Compare May 21, 2025 10:46
@potiuk
Copy link
Member Author

potiuk commented May 21, 2025

Only intermittent issues merging

@potiuk potiuk merged commit 611270a into apache:main May 21, 2025
90 of 92 checks passed
@potiuk potiuk deleted the split-openapi-generating-scripts branch May 21, 2025 11:32
Copy link

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 611270a v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

potiuk added a commit to potiuk/airflow that referenced this pull request May 21, 2025
)

The openapi generation scripts were run together for FAB and main
openapi from core - however we do not want to re-run those scripts at
all in non-main branch - i.e. branch we prepare providers from.

This PR splits the openapi script and removes all fab pre-commits from
running in non-main branch.
(cherry picked from commit 611270a)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk added a commit to potiuk/airflow that referenced this pull request May 21, 2025
)

The openapi generation scripts were run together for FAB and main
openapi from core - however we do not want to re-run those scripts at
all in non-main branch - i.e. branch we prepare providers from.

This PR splits the openapi script and removes all fab pre-commits from
running in non-main branch.
(cherry picked from commit 611270a)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk added a commit that referenced this pull request May 21, 2025
…50886)

The openapi generation scripts were run together for FAB and main
openapi from core - however we do not want to re-run those scripts at
all in non-main branch - i.e. branch we prepare providers from.

This PR splits the openapi script and removes all fab pre-commits from
running in non-main branch.
(cherry picked from commit 611270a)
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request May 21, 2025
The openapi generation scripts were run together for FAB and main
openapi from core - however we do not want to re-run those scripts at
all in non-main branch - i.e. branch we prepare providers from.

This PR splits the openapi script and removes all fab pre-commits from
running in non-main branch.
dadonnelly316 pushed a commit to dadonnelly316/airflow that referenced this pull request May 26, 2025
The openapi generation scripts were run together for FAB and main
openapi from core - however we do not want to re-run those scripts at
all in non-main branch - i.e. branch we prepare providers from.

This PR splits the openapi script and removes all fab pre-commits from
running in non-main branch.
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50886)

The openapi generation scripts were run together for FAB and main
openapi from core - however we do not want to re-run those scripts at
all in non-main branch - i.e. branch we prepare providers from.

This PR splits the openapi script and removes all fab pre-commits from
running in non-main branch.
(cherry picked from commit 611270a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/apache/airflow/pull/50875

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy