-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Do not run FAB pre-commits in release branches #50875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0a7527
to
a407a88
Compare
eladkal
approved these changes
May 21, 2025
amoghrajesh
approved these changes
May 21, 2025
a407a88
to
04cdda2
Compare
This was referenced May 21, 2025
gopidesupavan
approved these changes
May 21, 2025
This was referenced May 21, 2025
pierrejeambrun
approved these changes
May 21, 2025
The openapi generation scripts were run together for FAB and main openapi from core - however we do not want to re-run those scripts at all in non-main branch - i.e. branch we prepare providers from. This PR splits the openapi script and removes all fab pre-commits from running in non-main branch.
04cdda2
to
e354403
Compare
Only intermittent issues merging |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 611270a v3-0-test This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 21, 2025
) The openapi generation scripts were run together for FAB and main openapi from core - however we do not want to re-run those scripts at all in non-main branch - i.e. branch we prepare providers from. This PR splits the openapi script and removes all fab pre-commits from running in non-main branch. (cherry picked from commit 611270a) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 21, 2025
) The openapi generation scripts were run together for FAB and main openapi from core - however we do not want to re-run those scripts at all in non-main branch - i.e. branch we prepare providers from. This PR splits the openapi script and removes all fab pre-commits from running in non-main branch. (cherry picked from commit 611270a) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
May 21, 2025
…50886) The openapi generation scripts were run together for FAB and main openapi from core - however we do not want to re-run those scripts at all in non-main branch - i.e. branch we prepare providers from. This PR splits the openapi script and removes all fab pre-commits from running in non-main branch. (cherry picked from commit 611270a)
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
May 21, 2025
The openapi generation scripts were run together for FAB and main openapi from core - however we do not want to re-run those scripts at all in non-main branch - i.e. branch we prepare providers from. This PR splits the openapi script and removes all fab pre-commits from running in non-main branch.
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
The openapi generation scripts were run together for FAB and main openapi from core - however we do not want to re-run those scripts at all in non-main branch - i.e. branch we prepare providers from. This PR splits the openapi script and removes all fab pre-commits from running in non-main branch.
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
…50886) The openapi generation scripts were run together for FAB and main openapi from core - however we do not want to re-run those scripts at all in non-main branch - i.e. branch we prepare providers from. This PR splits the openapi script and removes all fab pre-commits from running in non-main branch. (cherry picked from commit 611270a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openapi generation scripts were run together for FAB and main openapi from core - however we do not want to re-run those scripts at all in non-main branch - i.e. branch we prepare providers from.
This PR splits the openapi script and removes all fab pre-commits from running in non-main branch.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.