-
Notifications
You must be signed in to change notification settings - Fork 15
📝 docs for local development on CPU #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to vLLM support on Spyre.
Or this can be done with
Now you are good to go 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think that this doc could get split up a bit. 🤔
-
For example, the installation part could be part of the general Installation doc but denoting that it's different way to install (for local dev on mac).
-
Running the tests could be a section in the
Contributing
guide. See https://docs.vllm.ai/en/stable/contributing/overview.html#developing for inspiration. -
Running the examples are a bit straightforward and I'm not really sure they require extra documentation except maybe in a future quickstart doc or in the Contributing guide too?
Thanks for the review Rafael!
|
98ee893
to
3fa80f4
Compare
b7b324e
to
bebeeb4
Compare
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
ff5aef1
to
5b55f39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's get it 👍
Add documentation on how to run the
eager
(CPU) examples + tests onarm64
andx86_64
.See it live - https://vllm-spyre--161.org.readthedocs.build/en/161/getting_started/local_development.html
Will wait for #159 to merge first