Use JSON stream parsing for lazy bulk queries #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset makes Bulk API's query and query_all methods use JSON stream parsing when lazy_opeartion flag is enabled. By doing so, the methods now avoid loading the entire batch results setup into memory unnessecarily. The code introduced can also automatically detect and handle gzip-encoded responses from the API, in cases where `Content-Encoding: gzip` header is inclued in the response. In order to achieve this, a depedency on package `ijson` was added.
Idan-Or
force-pushed
the
feature/json-stream-lazy-queries
branch
from
25c4ddb to
19ab46a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset makes Bulk API's query and query_all methods use JSON stream parsing when lazy_opeartion flag is enabled. By doing so, the methods now avoid loading the entire batch results setup into memory unnessecarily.
The code introduced can also automatically detect and handle gzip-encoded responses from the API, in cases where
Content-Encoding: gzipheader is inclued in the response.In order to achieve this, a depedency on package
ijsonwas added.