Content-Length: 288525 | pFad | http://github.com/nodejs/node/pull/58610

54 test: skip tests failing when run under root by LiviaMedeiros · Pull Request #58610 · nodejs/node · GitHub
Skip to content

test: skip tests failing when run under root #58610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LiviaMedeiros
Copy link
Member

No description provided.

@LiviaMedeiros LiviaMedeiros added test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. labels Jun 6, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/sqlite

Copy link

codecov bot commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (c1f090d) to head (6de2978).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58610      +/-   ##
==========================================
+ Coverage   90.20%   90.22%   +0.01%     
==========================================
  Files         636      636              
  Lines      187698   187698              
  Branches    36852    36854       +2     
==========================================
+ Hits       169316   169344      +28     
+ Misses      11165    11114      -51     
- Partials     7217     7240      +23     

see 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@geeksilva97
Copy link
Contributor

geeksilva97 commented Jun 7, 2025

out of curiosity, what does that isRoot mean, and why do we wanna skip these tests specifically?

@LiviaMedeiros
Copy link
Member Author

root is superuser, with UID === 0.
These two tests have to be skipped because they test inability of process to perform read/write operations on write/read-only file, and therefore fail because root ignores file permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/nodejs/node/pull/58610

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy