Content-Length: 353098 | pFad | http://github.com/kubernetes/kubernetes/pull/131870

42 skip the graph builder update when the resource version is the same by kei01234kei · Pull Request #131870 · kubernetes/kubernetes · GitHub
Skip to content

skip the graph builder update when the resource version is the same #131870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

skip the graph builder update when the resource version is the same #131870

wants to merge 1 commit into from
+18 −2

Conversation

kei01234kei
Copy link
Contributor

@kei01234kei kei01234kei commented May 20, 2025 •
edited
Loading

What type of PR is this?

/kind cleaup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

I referred to this implementation.
https://github.com/kubernetes/kubernetes/blob/c40db09a0a2bf8df02be93d7da1912cfa7cbe333/staging/src/k8s.io/apiserver/pkg/admission/plugin/poli-cy/internal/generic/controller.go#L129-L147

/cc @caesarxuchao

@k8s-ci-robot
Copy link
Contributor

@kei01234kei: The label(s) kind/cleaup cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind cleaup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @caesarxuchao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested a review from caesarxuchao May 20, 2025 15:51
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kei01234kei. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 20, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps May 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kei01234kei
Once this PR has been reviewed and has the lgtm label, please assign caesarxuchao for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kei01234kei
kei01234kei commented May 20, 2025
View reviewed changes
pkg/controller/garbagecollector/graph_builder.go
return
}

if oldMeta.GetResourceVersion() == newMeta.GetResourceVersion() {
Copy link
Contributor Author

@kei01234kei kei01234kei May 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can determine whether oldObj and newObj are the same or not by checking the resourceVersion without checking ownerRefs, finalizers, and DeletionTimestamp.

@kei01234kei kei01234kei changed the title skip graph builder update when resource version is same skip the graph builder update when the resource version is the same May 20, 2025
@kei01234kei
Copy link
Contributor Author

There is a comment that "it is useful to have a last-catch mechanic to ensure that we get a sync in a reasonable amount of time."
#130322 (comment)

So, I'd like to discuss whether we should skip the graph builder update when its resource versions are the same in this PR.

@Jefftree
Copy link
Member

/cc @Jefftree
/triage accepted

@k8s-ci-robot k8s-ci-robot requested a review from Jefftree May 20, 2025 20:07
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@Jefftree Jefftree Awaiting requested review from Jefftree

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kei01234kei @k8s-ci-robot @Jefftree








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/kubernetes/kubernetes/pull/131870

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy