Content-Length: 285948 | pFad | http://github.com/googleapis/langchain-google-firestore-python/pull/68

18 ci: Add mypy function type check by duwenxin99 · Pull Request #68 · googleapis/langchain-google-firestore-python · GitHub
Skip to content

ci: Add mypy function type check #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: Add mypy function type check #68

wants to merge 1 commit into from

Conversation

duwenxin99
Copy link
Contributor

disallow incomplete input and return types

@duwenxin99 duwenxin99 requested review from a team as code owners May 20, 2024 21:07
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/langchain-google-firestore-python API. label May 20, 2024
Copy link
Member

@JU-2094 JU-2094 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the lint is failing if the change is only to pyproject.toml

@averikitsch
Copy link
Collaborator

@JU-2094 We want to enforce this check but the source code needs to be updated to pass the lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/langchain-google-firestore-python API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/googleapis/langchain-google-firestore-python/pull/68

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy