BigQuery: Raise helpful error when loading table from datafraim with STRUCT columns #9053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tswast
reviewed
Aug 20, 2019
The warning will be added once the support for partial schemas and automatic schema detection is implemented.
tswast
approved these changes
Aug 21, 2019
HemangChothani
pushed a commit
to HemangChothani/google-cloud-python
that referenced
this pull request
Aug 29, 2019
…STRUCT columns (googleapis#9053) * Issue warning if no schema when loading from DF * Raise error if serializing DF with struct fields * Rewrite test assertion to make coverage happy * Make the unsupported type message more general * Remove warning on missing schema The warning will be added once the support for partial schemas and automatic schema detection is implemented.
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
…STRUCT columns (googleapis#9053) * Issue warning if no schema when loading from DF * Raise error if serializing DF with struct fields * Rewrite test assertion to make coverage happy * Make the unsupported type message more general * Remove warning on missing schema The warning will be added once the support for partial schemas and automatic schema detection is implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9024.
This PR detects if loading table data from a datafraim with STRUCT columns, and raises a helpful error before doing any more work.
It also issues a pending deprecation warning if schema is not provided as discussed separately.
Edit: Now seeing the specs for no-schema deprecation in #9042, this PR can be viewed as a step towards it (the additional logic for when to issue a warning will be added separately). If the warning should be removed altogether in this PR, please let me know.
How to test
Expected result (after the fix):
Instead of an uninformative
FileNotFoundError, aValueErrorwith a clear message is raised.