fix! [google-ai-generativelanguage] prevent 0xa api_key suffix #13963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
pnikonowicz
force-pushed
the
invalid_newline_char
branch
from
78cb52e to
12f1e33
Compare
if a 0xa character appears at the end of the api_key, the underlying grpc implementation will fail with an invalid value header error. see: https://gitlab.uni-hannover.de/tci-gateway-module/grpc/-/blob/v1.9.x/src/core/lib/surface/validate_metadata.cc#L84 to reproduce this, simply add a x0a character to an api_key and try to perform any generative action.
pnikonowicz
force-pushed
the
invalid_newline_char
branch
from
12f1e33 to
9867dad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a 0xa character appears at the end of
the api_key, the underlying grpc implementation
will fail with an invalid value header error.
see: https://gitlab.uni-hannover.de/tci-gateway-module/grpc/-/blob/v1.9.x/src/core/lib/surface/validate_metadata.cc#L84
to reproduce this, simply add a 0xa character to an api_key and try to perform any generative action via grpc transport.