chore: create statementParser struct and make it dialect-aware #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the statement parser into a struct that contains a field for the database dialect that is being used. This dialect field will be used in follow-up pull request to implement dialect-specific parsing.
olavloite
requested review from
rahul2393,
aakashanandg and
bhatt4982
and removed request for
rahul2393 and
aakashanandg
rahul2393
approved these changes
May 23, 2025
| if err != nil { | ||
| return "", nil, err | ||
| } | ||
| info := detectStatementType(sql) | ||
| statementsCache.Add(sql, &statementsCacheEntry{sql: namedParamsSql, params: params, info: info}) | ||
| info := p.detectStatementType(sql) |
There was a problem hiding this comment.
nit: params here if modified later will modify the cache entry also, if we don't want it we may want to
Return a defensive copy:
paramsCopy := append([]string(nil), res.params...)
return res.sql, paramsCopy, nil
Example: https://go.dev/play/p/L69JoBslaWl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the statement parser into a struct that contains a field for the database dialect that is being used. This dialect field will be used in follow-up pull request to implement dialect-specific parsing.