Content-Length: 292405 | pFad | http://github.com/codecov/codecov-api/pull/1297

6A fix: Attempt to fix segments error by RulaKhaled · Pull Request #1297 · codecov/codecov-api · GitHub
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

fix: Attempt to fix segments error #1297

Merged
merged 3 commits into from
Apr 28, 2025
Merged

fix: Attempt to fix segments error #1297

merged 3 commits into from
Apr 28, 2025

Conversation

RulaKhaled
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?
resolves https://codecov.sentry.io/issues/6345111741?groupId=6345111741&pageEnd=2025-04-24T08%3A00%3A23.567&pageStart=2025-04-23T08%3A00%3A23.567&project=5514400&query=useComparisonForCommitAndParent&referrer=issue-stream&sort=date&source=issue_details&stream_index=0

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link
Contributor

seer-by-sentry bot commented Apr 23, 2025

🚨 Sentry detected 1 potential issue in your recent changes 🚨

Lower risk findings

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.29%. Comparing base (18eb985) to head (d97d446).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
services/comparison.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1297      +/-   ##
==========================================
- Coverage   96.29%   96.29%   -0.01%     
==========================================
  Files         488      488              
  Lines       16995    16997       +2     
==========================================
+ Hits        16366    16367       +1     
- Misses        629      630       +1     
Flag Coverage Δ
unit 96.29% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/comparison.py 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@RulaKhaled RulaKhaled added this pull request to the merge queue Apr 28, 2025
Merged via the queue into main with commit 8527025 Apr 28, 2025
20 of 25 checks passed
@RulaKhaled RulaKhaled deleted the attempt-2 branch April 28, 2025 14:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/codecov/codecov-api/pull/1297

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy