Content-Length: 315919 | pFad | http://github.com/apache/airflow/pull/50934

25 Fix default deferrable checking script by Lee-W · Pull Request #50934 · apache/airflow · GitHub
Skip to content

Fix default deferrable checking script #50934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented May 22, 2025

Why

The checking path of scripts/ci/pre_commit/check_deferrable_default.py was not updated back to the time we reorganized the project structure.

What

  • Fix the checking path of scripts/ci/pre_commit/check_deferrable_default.py

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools area:providers provider:google Google (including GCP) related issues labels May 22, 2025
@Lee-W Lee-W changed the title Fix default deferrable checking script and PubSubPullOperator.deferable default Fix default deferrable checking script and PubSubPullOperator.deferable default value May 22, 2025
@Lee-W
Copy link
Member Author

Lee-W commented May 22, 2025

After a second thought, let me split this one to 2 PRs

@Lee-W Lee-W force-pushed the fix-default-deferrable-checking-script branch from 209e844 to b13fb76 Compare May 22, 2025 02:47
@Lee-W Lee-W changed the title Fix default deferrable checking script and PubSubPullOperator.deferable default value Fix default deferrable checking script May 22, 2025
@Lee-W Lee-W marked this pull request as draft May 22, 2025 02:48
@Lee-W Lee-W marked this pull request as ready for review May 22, 2025 02:56
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks, only a small nit for regex matching.

@Lee-W Lee-W merged commit 8e97af0 into apache:main May 22, 2025
77 checks passed
@Lee-W Lee-W deleted the fix-default-deferrable-checking-script branch May 22, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/apache/airflow/pull/50934

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy