Content-Length: 293543 | pFad | http://github.com/apache/airflow/pull/50932

D2 Add missing airflow.sdk.definitions.mappedoperator.MappedOperator import to prevent operator_extra_links property failing by valentinDruzhinin · Pull Request #50932 · apache/airflow · GitHub
Skip to content

Add missing airflow.sdk.definitions.mappedoperator.MappedOperator import to prevent operator_extra_links property failing #50932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing airflow.sdk.definitions.mappedoperator.MappedOperator import to prevent operator_extra_links property failing #50932

wants to merge 1 commit into from
+1 −1

Conversation

valentinDruzhinin
Copy link
Contributor

Add missing airflow.sdk.definitions.mappedoperator.MappedOperator import to prevent operator_extra_links property failing for Airflow 3.

closes: #50535

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels May 22, 2025
@valentinDruzhinin valentinDruzhinin force-pushed the fix-50535 branch 2 times, most recently from 7f0c2cc to 768bbd9 Compare May 22, 2025 04:08
@uranusjr
Copy link
Member

Probably better to switch the check to use task.is_mapped instead. That works since operator mapping was introduced.

@valentinDruzhinin
Copy link
Contributor Author

Probably better to switch the check to use task.is_mapped instead. That works since operator mapping was introduced.

Right now we are failing here: https://github.com/apache/airflow/blob/main/providers/amazon/src/airflow/providers/amazon/aws/operators/batch.py#L156
Because our mappedOperator instance doesn't pass the instance check correctly.

@uranusjr could you please point where exactly you think I need to add this check for task.is_mapped? Because I can't even find the place where task.is_mapped used.
Thanks

Add missing airflow.sdk.definitions.mappedoperator.MappedOperator imp…
c2c7d6f 
…ort to prevent operator_extra_links property failing
@valentinDruzhinin
Copy link
Contributor Author

Probably better to switch the check to use task.is_mapped instead. That works since operator mapping was introduced.

I got what you mean :) Thanks, updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladkal eladkal Awaiting requested review from eladkal eladkal is a code owner

@o-nikolas o-nikolas Awaiting requested review from o-nikolas o-nikolas is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:providers provider:amazon AWS/Amazon - related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BatchOperator incompatible with airflow 3
2 participants
@valentinDruzhinin @uranusjr








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/apache/airflow/pull/50932

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy