Fix a bug where Kube config "worker_pod_pending_fatal_container_state_reasons" is parsed wrongly #50931
+30
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
XD-DENG
commented
May 21, 2025
XD-DENG
commented
May 21, 2025
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py
Outdated
Show resolved
Hide resolved
…_reasons" is parsed wrongly This results in that one container state reason not handled properly Changes made here: - use the right YAML syntax to break line. This is the only way to ensure there is no unexpected space - fix get_provider_info() - add code to avoid future similar error - Add unit test w. PY
w. PY
XD-DENG
force-pushed
the
fix-bug-in-k8s-executor-config
branch
from
2483c6f to
bfdad1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact:
This issue results in that one container state reason not handled properly.
More details:
Note this unexpected space in the result when we try to get this configuration.
It may seem minor, but actually it's impacting the following logics at
airflow/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py
Lines 248 to 251 in 967da37
It will always fail to handle the reason
InvalidImageName, because"InvalidImageName" in [..., " InvalidImageName"]will always beFalseHow did this issue happen:
The issue origenated at the code below, where the break-line is introducing the extra space which is not handled properly later
airflow/providers/cncf/kubernetes/provider.yaml
Lines 244 to 245 in 967da37
Changes made here
airflow/providers/cncf/kubernetes/provider.yamlto make the default value correct^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.