-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Add German UI translation #50929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add German UI translation #50929
Conversation
}, | ||
"nav": { | ||
"home": "Start", | ||
"assets": "Assets", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I'd assume that terms like "Assets" are not translated. Else it would be "Anlage" but as technical terms and translation will be confusing would propose to keep Assets.
Same for "Pools" and "Providers" (would be "Prozess-Gruppe" and "Diensteanbieter")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I know @RoyLee1224 kept "Providers" and "XComs" in the chinese translation. But we probably need to decide on a list of terms which we would try to keep instead of literally translate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fully agree. So adding translations get new problems.
When I take a look in zh_TW the following terms are kept:
- Dag
- Provider
- Uri
- Xcoms
In my proposal I'd keep:
- Assets <-- DIFF!
- Dag
- Pools <-- DIFF!
- Provider
- Task <-- DIFF (Translation would be "Aufgabe")
- Uri
- XComs (Actually is the C upper- or lower case? in zh_TW the C is lower case.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm maybe we should keep it in a common.core_concepts
list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mandarin is not yet fully translated and is currently a work in progress 🤔 Dag is probably the thing we can not translate based on what we discussed a few months ago as it's a term only for airflow, not the mathematical ones. Other thing might be able to be translated though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure whether the "depth" of translation is something that might be different per region or something the UI developer should decide? I think it is partly confusing when we translate "Asset" in the UI and every piece in the Dag code has asset if you program it - as well as the term will be un-translated in the logs.
Do we know any UI translation expert that knows common rules for translations in UI? Shall we raise a discussion in devlist?
I would see some categories:
(1) Terms which are clearly not to be translated (should have a README on this - still I'd propose to put them to the language files as plural's pre-fixes in some translation might be happening)
- Dag
- Uri
(2) Terms that we should define if we want to translate them or expect rather far that we confuse user if the UI names it X and in code and logs you anyway will find Y - that I assume we should discuss if it should go in (1) or (3) (and I am not an expert):
- Asset
- Provider
- XCom
- Pools
(3) Terms that we recommend to translate if the target language has a meaningful term:
- Home
- User
- Task
- Variables
- Connections
- Plugins
- Dark Mode
Fun story: I once hat this in an IBM product that the action similar to "git commit" was translated to "Festschreiben" in the UI and I did not understand where to click to "Save". Was thinking about this, would it be translated to "Festschreibe-Protokoll" today if I want to see "git log"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Festschreiben" would have confused me as well 😅
Yeah it is tricky, I am also not an expert but I definitely agree that dag, uri, asset, XCom and Pools (even if "Däg" and "Schwimmbäder" would be funny).
With "Provider" I think in Airflow its meaning has strayed from "Anbieter" so I lean toward not translating as well, but could see that translated in other UIs.
Bei "task" bin ich mir unsicher, ich denke da ist gut beides möglich, so lassen oder als "Aufgabe" übersetzen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is partly confusing when we translate "Asset" in the UI and every piece in the Dag code has asset if you program it
I think we can allow some users to read asset history and other information without permitting them to read the dag code. (Please correct me if I'm wrong, as I'm unfamiliar with this part of Airflow. 🤦♂️ )
I actually think it makes sense to display "資源" on UI while the code continues to use "assets." This might highlight one potential reason why the translation depth could vary across different languages.
Shall we raise a discussion in devlist?
That sounds like a good idea. I'm not an expert either. If we want to bring it to the dev list, maybe I can do it later today or early tomorrow.
(2) Terms that...
XCom is a tricky one. It's an abbreviation that has no meaning on its own. I probably would suggest avoiding translating it unless someone has a better idea. However, "pools" does have its own meaning, and I think it's frequently translated into Mandarin.
Fun story: I once hat this in an IBM product that the action similar to "git commit"...
TBH, I don’t expect to use this feature myself. Sometimes, I struggle with the Mandarin translations of many technical terms. 😆
However, I believe we’re creating this for those who may not be as familiar or comfortable with English, aiming to help them connect with Airflow as much as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback - translated a bit more "agressive" now in the last commit - @TJaniF can you re-review?
cc @TJaniF if you want to check any translations |
Let's rebase after the changes in #50930 |
af7217e
to
9dd9b9f
Compare
After #50626 this adds German as language. Would also offer to take the CODEOWNER-ship to maintain German translation.
(Updated from commit 9dd9b9f):
