Add soft-delete support and set dag_version FK on delete to SET NULL #50922
+1,445
−1,291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
sunank200
force-pushed
the
delete-dag-version-records
branch
2 times, most recently
from
644ce09 to
0020deb
Compare
sunank200
force-pushed
the
delete-dag-version-records
branch
2 times, most recently
from
8e07a32 to
14a5876
Compare
sunank200
requested review from
ephraimbuddy,
pierrejeambrun,
rawwar,
jason810496,
bugraoz93,
shubhamraj-git,
XD-DENG and
ashb
as code owners
uranusjr
reviewed
May 22, 2025
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/grid.py
Outdated
Show resolved
Hide resolved
uranusjr
reviewed
May 22, 2025
airflow-core/src/airflow/migrations/versions/0072_3_1_0_modify_taskinstance_dag_version_fk.py
Outdated
Show resolved
Hide resolved
Lee-W
reviewed
May 22, 2025
airflow-core/src/airflow/migrations/versions/0071_3_1_0_add_is_active_to_dag_version.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/migrations/versions/0072_3_1_0_modify_taskinstance_dag_version_fk.py
Show resolved
Hide resolved
airflow-core/src/airflow/migrations/versions/0072_3_1_0_modify_taskinstance_dag_version_fk.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/migrations/versions/0072_3_1_0_modify_taskinstance_dag_version_fk.py
Show resolved
Hide resolved
sunank200
force-pushed
the
delete-dag-version-records
branch
2 times, most recently
from
3ed69fc to
e6947f5
Compare
Lee-W
approved these changes
May 22, 2025
airflow-core/src/airflow/migrations/versions/0071_3_1_0_add_is_active_to_dag_version.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/migrations/versions/0072_3_1_0_modify_taskinstance_dag_version_fk.py
Outdated
Show resolved
Hide resolved
sunank200
force-pushed
the
delete-dag-version-records
branch
from
445f8d9 to
8d042f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces soft-delete for DAG versions and changes the foreign-key behaviour on
task_instance.dag_version_idso that deleting a version no longer cascades, but instead sets the reference toNULL.closes: #49580
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.