Bugfix: Logical date isn't populated in Context vars: #50898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests was overusing mocking so the error was hidden! I found that while migrating `ti.run()` to Task SDK execution path.
kaxil
added
the
backport-to-v3-0-test
dstandish
approved these changes
May 21, 2025
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
May 21, 2025
…ache#50898) The tests was overusing mocking so the error was hidden! I found that while migrating `ti.run()` to Task SDK execution path. (cherry picked from commit e52e8ac) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
May 21, 2025
The tests was overusing mocking so the error was hidden! I found that while migrating `ti.run()` to Task SDK execution path.
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
May 22, 2025
This is the last thing to remove the parallel execution path. For simplicity, `ti.run` and `ti._run_raw_task` have been retained, but they now use the Task SDK execution path. They have been retained so we don't have to make big bang changes in tests and PR remains relatively review-able. There are opportunities for evaluating & cleanup after this PR is merged: - `get_template_context`, - `handle_failure`, - `check_and_change_state_before_execution` - and probably a lot more. The following bugs/missing features were identified and implemented: - Running `on_kill` on the Task SDK execution path - Resolving lazy_object_proxies in the Context dict when running with a VirtualEnvOperator - apache#50898
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
May 22, 2025
This is the last thing to remove the parallel execution path. For simplicity, `ti.run` and `ti._run_raw_task` have been retained, but they now use the Task SDK execution path. They have been retained so we don't have to make big bang changes in tests and PR remains relatively review-able. There are opportunities for evaluating & cleanup after this PR is merged: - `get_template_context`, - `handle_failure`, - `check_and_change_state_before_execution` - and probably a lot more. The following bugs/missing features were identified and implemented: - Running `on_kill` on the Task SDK execution path - Resolving lazy_object_proxies in the Context dict when running with a VirtualEnvOperator - apache#50898
kaxil
added a commit
that referenced
this pull request
May 22, 2025
This is the last thing to remove the parallel execution path. For simplicity, `ti.run` and `ti._run_raw_task` have been retained, but they now use the Task SDK execution path. They have been retained so we don't have to make big bang changes in tests and PR remains relatively review-able. There are opportunities for evaluating & cleanup after this PR is merged: - `get_template_context`, - `handle_failure`, - `check_and_change_state_before_execution` - and probably a lot more. The following bugs/missing features were identified and implemented: - Running `on_kill` on the Task SDK execution path - Resolving lazy_object_proxies in the Context dict when running with a VirtualEnvOperator - #50898
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
May 22, 2025
This is the last thing to remove the parallel execution path. For simplicity, `ti.run` and `ti._run_raw_task` have been retained, but they now use the Task SDK execution path. They have been retained so we don't have to make big bang changes in tests and PR remains relatively review-able. There are opportunities for evaluating & cleanup after this PR is merged: - `get_template_context`, - `handle_failure`, - `check_and_change_state_before_execution` - and probably a lot more. The following bugs/missing features were identified and implemented: - Running `on_kill` on the Task SDK execution path - Resolving lazy_object_proxies in the Context dict when running with a VirtualEnvOperator - apache#50898 (cherry picked from commit f1ca1d1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests was overusing mocking so the error was hidden!
I found that while migrating
ti.run()to Task SDK execution path.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.