Mask secrets when retrieving variables from secrets backend #50895
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this mask ALL |
|
@jroachgolf84 not all. Only the ones that are deemed sensitive. |
uranusjr
reviewed
May 22, 2025
| @@ -180,6 +181,7 @@ def _get_variable(key: str, deserialize_json: bool) -> Any: | |||
| import json | |||
|
|
|||
| var_val = json.loads(var_val) | |||
| mask_secret(var_val, key) # type: ignore[arg-type] | |||
There was a problem hiding this comment.
We should probably not type-ignore this but actually check the type? var_val can technically be a number or even None.
There was a problem hiding this comment.
Valid that it can be a number but the "None" type is covered above on line 179
There was a problem hiding this comment.
Handled it for the case of "str" because secrets_backend.get_variable(key=key) returns str | None.
amoghrajesh
added
the
backport-to-v3-0-test
|
@uranusjr could you take a look at this when you get some time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to this: #50880 (comment)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.