AIP-81: Update Transition of Jobs Command. #50837
Open
+36
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prab-27
force-pushed
the
aip-81-transition-of-jobs-command
branch
from
c60a9e3 to
fc8a862
Compare
Prab-27
requested review from
vincbeck,
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
shubhamraj-git
as code owners
bugraoz93
requested changes
May 20, 2025
| @@ -502,7 +502,7 @@ def list( | |||
| ) -> JobCollectionResponse | ServerResponseError: | |||
| """List all jobs.""" | |||
| try: | |||
| params = {"limit": limit, "job_type": job_type, "hostname": hostname, "is_alive": is_alive} | |||
| params = {limit: limit, "job_type": job_type, "hostname": hostname, is_alive: is_alive} | |||
There was a problem hiding this comment.
Suggested change
| params = {limit: limit, "job_type": job_type, "hostname": hostname, is_alive: is_alive} | |
| params = {"limit": limit, "job_type": job_type, "hostname": hostname, "is_alive": is_alive} |
Key of limit shouldn't be an integer here, same for is_alive shouldn't be a bool.
We should include all the filters here
We shouldn't include the limit here since we should either filter or return the full result. See the above endpoint, it is very similar to all the list methods on the API side. It will be very similar to the return of all entities that you are working on. We shouldn't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #45666
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.