Stabilize FAB asset compilation #50829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
stabilize-fab-asset-compilation
branch
from
9ce3c91 to
5f6e74f
Compare
The FAB asset compilation might trigger different results depending on time/libraries it is run with. Since we commit generated files to repository, we should also commit the hash file of the www directory so that we only trigger rebuild when any of the www files change. Previously we stored the hash in `.build` directory which was not committed to the repo - which works fine for dynamic assset generation we have for the UI, but since FAB assets change rarely - we commmit the generated files, and we should also commit the hash file in this case.
potiuk
force-pushed
the
stabilize-fab-asset-compilation
branch
from
5f6e74f to
a28ce9c
Compare
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 21, 2025
The FAB asset compilation might trigger different results depending on time/libraries it is run with. Since we commit generated files to repository, we should also commit the hash file of the www directory so that we only trigger rebuild when any of the www files change. Previously we stored the hash in `.build` directory which was not committed to the repo - which works fine for dynamic assset generation we have for the UI, but since FAB assets change rarely - we commmit the generated files, and we should also commit the hash file in this case. (cherry picked from commit 0a3b58a) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
May 21, 2025
The FAB asset compilation might trigger different results depending on time/libraries it is run with. Since we commit generated files to repository, we should also commit the hash file of the www directory so that we only trigger rebuild when any of the www files change. Previously we stored the hash in `.build` directory which was not committed to the repo - which works fine for dynamic assset generation we have for the UI, but since FAB assets change rarely - we commmit the generated files, and we should also commit the hash file in this case. (cherry picked from commit 0a3b58a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FAB asset compilation might trigger different results depending on time/libraries it is run with. Since we commit generated files to repository, we should also commit the hash file of the www directory so that we only trigger rebuild when any of the www files change.
Previously we stored the hash in
.builddirectory which was not committed to the repo - which works fine for dynamic assset generation we have for the UI, but since FAB assets change rarely - we commmit the generated files, and we should also commit the hash file in this case.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.