Add endpoint for DB stats #50758
Draft
Add endpoint for DB stats #50758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:airflow-ctl
area:API
| from airflow.utils.db import reflect_tables | ||
| from airflow.utils.db_cleanup import _effective_table_names, calculate_table_size | ||
|
|
||
| db_router = AirflowRouter(tags=["Maintenance"], prefix="/maintenance/db") |
There was a problem hiding this comment.
Not sure about the maintenance prefix/tag. Maybe db is good enough ?
Comment on lines
+528
to
+534
| def calculate_table_size( | ||
| *, | ||
| table_name: str, | ||
| session: Session, | ||
| ) -> float | None: | ||
| """Calculate table size in megabytes.""" | ||
| return 0 |
There was a problem hiding this comment.
Looks like the implementation is not done yet.
There was a problem hiding this comment.
Yeah. Wanted to keep few issues as good first issues for MLH internship folks to pick them up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am adding an endpoint to retrieve DB stats. For now, I am including only the table's name, the oldest record present in the table, and the number of records in the table. This can be extended in the future.
TODO:
Add additional field to TableStats for size of the table in MB - Very useful to determine if a clean up is necessarywill be doing this as part of a separate PR