-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Add delete_by_property method in weaviate hook #50735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Lee-W
merged 11 commits into
apache:main
from
sjyangkevin:issues/42565/add-delete-by-properties-to-weaviate-hook
May 27, 2025
Merged
Add delete_by_property method in weaviate hook #50735
Lee-W
merged 11 commits into
apache:main
from
sjyangkevin:issues/42565/add-delete-by-properties-to-weaviate-hook
May 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a609c21
to
f65174f
Compare
Add a DAG test, which delete the objects properly. Test Scenarios
|
Lee-W
reviewed
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good. left a few nits
f65174f
to
55772ae
Compare
0217d64
to
51d15e3
Compare
Lee-W
reviewed
May 20, 2025
providers/weaviate/src/airflow/providers/weaviate/hooks/weaviate.py
Outdated
Show resolved
Hide resolved
51d15e3
to
55c377f
Compare
…llections based on various filtering criteria
55c377f
to
ca11712
Compare
Lee-W
approved these changes
May 27, 2025
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* implement delete_by_properties method to allow deleting objects in collections based on various filtering criteria * allow only str for property name * add a parameter to allow filter by property name * add unit test for delete_by_properties * externalize the definition of filter criteria * fix spell check * use self.get_collection instead of client.collections.get * enforce keyword arguments and explicit error catch * refine exception and test cases * verify exception and add logging for dry run * update exception
jose-lehmkuhl
pushed a commit
to jose-lehmkuhl/airflow
that referenced
this pull request
Jul 11, 2025
* implement delete_by_properties method to allow deleting objects in collections based on various filtering criteria * allow only str for property name * add a parameter to allow filter by property name * add unit test for delete_by_properties * externalize the definition of filter criteria * fix spell check * use self.get_collection instead of client.collections.get * enforce keyword arguments and explicit error catch * refine exception and test cases * verify exception and add logging for dry run * update exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
By adding the
delete_by_property
method, users can delete multiple objects in multiple collections based on various filtering criteria, making data management more targeted and efficient.Close #42565
Reference
https://weaviate.io/developers/weaviate/search/filters
https://weaviate.io/developers/weaviate/manage-data/delete#delete-multiple-objects
Testing
Testing Code Sample
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.