-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Make dag_run.conf nullable in Details page #50719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugraoz93
approved these changes
May 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Rebase needed due to some CI faluire and for a clean history :)
@bugraoz93 |
pierrejeambrun
approved these changes
May 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
github-actions bot
pushed a commit
that referenced
this pull request
May 20, 2025
(cherry picked from commit e6282e0) Co-authored-by: ayush3singh <yesayushcan@gmail.com>
potiuk
pushed a commit
that referenced
this pull request
May 21, 2025
(cherry picked from commit e6282e0) Co-authored-by: ayush3singh <yesayushcan@gmail.com>
pierrejeambrun
pushed a commit
that referenced
this pull request
May 21, 2025
(cherry picked from commit e6282e0) Co-authored-by: ayush3singh <yesayushcan@gmail.com>
potiuk
pushed a commit
that referenced
this pull request
May 21, 2025
(cherry picked from commit e6282e0) Co-authored-by: ayush3singh <yesayushcan@gmail.com>
potiuk
pushed a commit
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:airflow-ctl
area:API
Airflow's REST/HTTP API
area:UI
Related to UI/UX. For Frontend Developers.
backport-to-v3-0-test
Mark PR with this label to backport to v3-0-test branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50386
As part of Airflow 2 to 3 migration we noticed dag_run.json became a JSON field. Since we don't need this in non-production we deleted the column and added new one with JSON type which is nullable as per the migration. But it's not nullable in the pydantic definition thus causing API error when a dagrun with null conf is present.
This PR changed schema conf as nullable and generated files for the change