Use GitHub API to download constraint files and avoid rate limiting #50716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
potiuk,
ashb,
jedcunningham and
gopidesupavan
as code owners
|
I think the response we get it from github api is base64 , we need to decode that.? |
potiuk
added
the
backport-to-v3-0-test
Nice catch indeed - i had no idea that you cannot pu t authorization in raw URL |
potiuk
reviewed
May 17, 2025
potiuk
approved these changes
May 17, 2025
|
I think we have other places in some bash scripts and yaml files where we are using |
|
Very good catch @amoghrajesh ! |
Yep, will do! |
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
May 17, 2025
…e limiting (apache#50716) (cherry picked from commit 35a4ced) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been hitting GH rate limiting quite frequently in the CI during last few days. On further checking,
it looks like we pass down the GITHUB_TOKEN to the breeze commands but we do not use GH API's and
instead use raw github, which doesn't need the tokens and hence doesn't follow the trajectory for fixing rate limiting.
Ref here: https://stackoverflow.com/questions/77054807/how-do-you-use-raw-githubusercontent-com-in-a-github-action#comment135840009_77054807
Works as expected:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.