[v3-0-test] Fix Pydantic ForwardRef error by reordering discriminated union definitions (#50688)
#50691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jedcunningham
requested review from
jedcunningham and
ephraimbuddy
as code owners
jedcunningham
approved these changes
May 16, 2025
…ated union definitions (#50688) In some rare cases, the DAG parse subprocess (`DagFileProcessorProcess`) could raise a `PydanticUserError` related to unresolved ForwardRefs in the discriminated union ToDagProcessor. This was caused by `TypeAdapter[ToDagProcessor]` being instantiated before `DagFileParseRequest` was defined. While this is not always reproducible, it can happen in forked subprocesses depending on import order. This change moves the union definitions (`ToDagProcessor`, `ToManager`) after the relevant Pydantic models are declared, ensuring all references are fully resolved at definition time. closes #50530 (cherry picked from commit 672ec99) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
kaxil
force-pushed
the
backport-672ec99-v3-0-test
branch
from
5ed715b to
b9f9aa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases, the DAG parse subprocess (
DagFileProcessorProcess) could raise aPydanticUserErrorrelated to unresolved ForwardRefs in the discriminated union ToDagProcessor.This was caused by
TypeAdapter[ToDagProcessor]being instantiated beforeDagFileParseRequestwas defined. While this is not always reproducible, it can happen in forked subprocesses depending on import order.This change moves the union definitions (
ToDagProcessor,ToManager) after the relevant Pydantic models are declared, ensuring all references are fully resolved at definition time.closes #50530
(cherry picked from commit 672ec99)
Co-authored-by: Kaxil Naik kaxilnaik@gmail.com