Fix version validation script for building docker images #50668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example failure: https://github.com/apache/airflow/actions/runs/15053245013/job/42312930970 Previously, the script used string-based sorting of PyPI releases, which caused versions like 2.11.0 to be incorrectly excluded (e.g. sorted behind 2.9.x). This commit updates the logic to use semantic versioning via `packaging.version.Version`. Before: ``` ❯ uv run scripts/ci/airflow_version_check.py 2.11.0rc1 Version 2.11.0rc1 is not a valid Airflow version Available versions: (first available 30 versions): ['3.0.1rc1', '3.0.1', '3.0.0rc4', '3.0.0rc3', '3.0.0rc2', '3.0.0rc1.post4', '3.0.0rc1.post3', '3.0.0rc1.post2', '3.0.0rc1.post1', '3.0.0rc1', '3.0.0b4', '3.0.0', '2.9.3rc1', '2.9.3', '2.9.2rc1', '2.9.2', '2.9.1rc2', '2.9.1rc1', '2.9.1', '2.9.0rc3', '2.9.0rc2', '2.9.0rc1', '2.9.0b2', '2.9.0b1', '2.9.0', '2.8.4rc1', '2.8.4', '2.8.3rc1', '2.8.3', '2.8.2rc3'] ``` After: ``` ❯ uv run scripts/ci/airflow_version_check.py 2.11.0rc1 Checking constraints file: https://raw.githubusercontent.com/apache/airflow/constraints-2.11.0rc1/constraints-3.9.txt Constraints file found for version 2.11.0rc1, Python 3.9 airflowVersion=2.11.0rc1 airflowVersion=2.11.0rc1 skipLatest=true skipLatest=true ```
jedcunningham
approved these changes
May 15, 2025
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example failure: https://github.com/apache/airflow/actions/runs/15053245013/job/42312930970
Previously, the script used string-based sorting of PyPI releases, which caused versions like 2.11.0 to be incorrectly excluded (e.g. sorted behind 2.9.x). This commit updates the logic to use semantic versioning via
packaging.version.Version.Before:
After:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.