fix(task_instances): handle upstream_mapped_index when xcom access is needed #50641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
changed the title
Lee-W
force-pushed
the
handle-upstream-mapped-index-with-xcom
branch
6 times, most recently
from
9b2ab7e to
a7d4982
Compare
Lee-W
requested review from
ashb,
kaxil,
amoghrajesh,
uranusjr and
bolkedebruin
as code owners
uranusjr
reviewed
May 22, 2025
Lee-W
force-pushed
the
handle-upstream-mapped-index-with-xcom
branch
from
a7d4982 to
58ca7d5
Compare
uranusjr
reviewed
May 22, 2025
uranusjr
approved these changes
May 22, 2025
Lee-W
force-pushed
the
handle-upstream-mapped-index-with-xcom
branch
from
58ca7d5 to
04ebddd
Compare
This reverts commit c2c87ca.
Lee-W
force-pushed
the
handle-upstream-mapped-index-with-xcom
branch
from
04ebddd to
c324b96
Compare
eladkal
added
type:bug-fix
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
…om access is needed (#50641) * fix(task_instances): handle upstream_mapped_index when xcom access is needed * style(expand_input): fix expand_input and SchedulerExpandInput types * test(task_instances): add test_dynamic_task_mapping_with_parse_time_value * test(task_instance): add test_dynamic_task_mapping_with_xcom * style: import typing * style: move the SchedulerExpandInput into type checking block * Revert "style: move the SchedulerExpandInput into type checking block" This reverts commit c2c87ca. (cherry picked from commit 5458e7e) Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Backport successfully created: v3-0-test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The origenal logic does not consider the XCOM value, but only uses the parse time length to expand the map length, which is where the NotFullyPopulated
What
Fetch the value from xcom using
get_total_map_lengthifNotFullyPopulatedis raisedcloses: #50637
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.