Activate assets before adding trigger references #50638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
activate-asset-before-trigger-references
branch
from
85070d5 to
69f0b21
Compare
Active assets are referenced when we check what triggers to track for asset events. If we activate assets after adding triggers, new assets will need to wait for an extra round to be picked up. This is functionally fine, but there's also no reason why we can't have them picked up earlier, without having to wait an extra parsing iteration.
The dag_maker activates assets and establish relations eagerly, complicating test setup. Since we're testing the dag and asset collection logic in the dag processor, it's better to use the user-facing classes directly since that is the layer the processor is dealing with.
uranusjr
force-pushed
the
activate-asset-before-trigger-references
branch
from
69f0b21 to
e8a396a
Compare
Lee-W
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active assets are referenced when we check what triggers to track for asset events.
airflow/airflow-core/src/airflow/dag_processing/collection.py
Line 833 in 08cc57d
If we activate assets after adding triggers, new assets will need to wait for an extra round to be picked up. This is functionally fine, but there's also no reason why we can't have them picked up earlier, without having to wait an extra parsing iteration.