Content-Length: 381755 | pFad | http://github.com/apache/airflow/pull/50424

8C feat (airflowctl): add dag operations to conform all API endpoints by jx2lee · Pull Request #50424 · apache/airflow · GitHub
Skip to content

feat (airflowctl): add dag operations to conform all API endpoints #50424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 17, 2025
Merged

feat (airflowctl): add dag operations to conform all API endpoints #50424

merged 4 commits into from
May 17, 2025

Conversation

jx2lee
Copy link
Contributor

@jx2lee jx2lee commented May 10, 2025 •
edited
Loading

closes: #45665

TBU: Local test w/ breeze

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@jx2lee
Copy link
Contributor Author

jx2lee commented May 10, 2025

@bugraoz93
https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#operation/get_dag_runs

Does it need adding all query parameters to operation method? Existed method like Get Dag Runs, doesn't have all parameters.

@bugraoz93
Copy link
Contributor

@bugraoz93 https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#operation/get_dag_runs

Does it need adding all query parameters to operation method? Existed method like Get Dag Runs, doesn't have all parameters.

Yes, it would be ideal to include those parameters as well, but we can exclude DagRun from the scope of this one.

bugraoz93
bugraoz93 reviewed May 10, 2025
View reviewed changes
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direction looks good!
These should also be under the dag operations.

  • dag_version
  • dag_warnings
  • dag_stats
  • dag_list_import_errors

@jx2lee jx2lee force-pushed the airflowctl-dag branch 3 times, most recently from d58034e to bd25d9f Compare May 12, 2025 15:18
@jx2lee jx2lee marked this pull request as ready for review May 15, 2025 13:08
@jx2lee jx2lee requested review from kaxil and potiuk as code owners May 15, 2025 13:08
@jx2lee jx2lee requested a review from bugraoz93 May 15, 2025 13:08
@jx2lee jx2lee force-pushed the airflowctl-dag branch 3 times, most recently from 6bc777c to 020f72c Compare May 15, 2025 21:56
@bugraoz93
Copy link
Contributor

Thanks for the updates! I will check this in detail tomorrow :)

bugraoz93
bugraoz93 approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @jx2lee!

@jx2lee
Copy link
Contributor Author

jx2lee commented May 17, 2025 •
edited
Loading

Looks good! Thanks @jx2lee!

Thanks for review @bugraoz93 🙏
Is there any ongoing issue related to remote CLI? It's such an interesting topic—I’d love to keep contributing.

@bugraoz93
Copy link
Contributor

Looks good! Thanks @jx2lee!

Thanks for review @bugraoz93 🙏 Is there any ongoing issue related to remote CLI? It's such an interesting topic—I’d love to keep contributing.

I saw you have already found one. Thanks! :)

@bugraoz93
Copy link
Contributor

Rebasing and merging :)

@bugraoz93 bugraoz93 merged commit 5785597 into apache:main May 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bugraoz93 bugraoz93 bugraoz93 approved these changes

@jason810496 jason810496 jason810496 approved these changes

@kaxil kaxil Awaiting requested review from kaxil kaxil is a code owner

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

Assignees
No one assigned
Labels
area:airflow-ctl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-81 Transition of DAG Command
3 participants
@jx2lee @bugraoz93 @jason810496








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/apache/airflow/pull/50424

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy