Implementing log_url on RuntimeTaskInstance in task sdk
#50376
Merged
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:Executors-core
|
@tirkarthi for review and guidence |
amoghrajesh
reviewed
May 9, 2025
ayush3singh
force-pushed
the
issue_50330
branch
4 times, most recently
from
0e285f2 to
a591c6d
Compare
|
@amoghrajesh please review Thanks |
amoghrajesh
reviewed
May 10, 2025
providers/openlineage/src/airflow/providers/openlineage/utils/utils.py
Outdated
Show resolved
Hide resolved
ayush3singh
force-pushed
the
issue_50330
branch
3 times, most recently
from
43f57d1 to
d07bd3c
Compare
ayush3singh
requested review from
potiuk,
jedcunningham and
gopidesupavan
as code owners
ayush3singh
force-pushed
the
issue_50330
branch
4 times, most recently
from
d969b1b to
ea00cd9
Compare
amoghrajesh
changed the title
log_url on RuntimeTaskInstance in task sdk
amoghrajesh
approved these changes
May 12, 2025
There was a problem hiding this comment.
LGTM +1, thanks.
@mobuchowski are you ok with the OL side of things?
kacpermuda
reviewed
May 12, 2025
…ng taskrunner startup
amoghrajesh
approved these changes
May 16, 2025
kacpermuda
approved these changes
May 16, 2025
|
Yes @amoghrajesh , looks good, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50330
The
log_urlvariable is required in theemail.htmltemplate. Since the configuration has been removed it is raising exception whenlog_urlandmark_success_urlis being used to send email notifications.This PR adds both to the task instance context
(context.ti)during execution.In previous versions of Airflow, during execution
ti.log_urlwas available,This PR introduces the following changes:
log_urltoRuntimeTaskInstancelog_urlproperty totiinget_template_contextsince context['ti'] needs to have log_url