Content-Length: 354787 | pFad | http://github.com/apache/airflow/pull/50328

22 Make is_stdout work when sys.stdout does not have a fd by quentin-sommer · Pull Request #50328 · apache/airflow · GitHub
Skip to content

Make is_stdout work when sys.stdout does not have a fd #50328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2025
Merged

Make is_stdout work when sys.stdout does not have a fd #50328

merged 2 commits into from
May 22, 2025

Conversation

quentin-sommer
Copy link
Contributor

@quentin-sommer quentin-sommer commented May 8, 2025 •
edited
Loading

closes #50240

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented May 8, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@quentin-sommer quentin-sommer force-pushed the main branch 3 times, most recently from 8ba8d66 to a4b3059 Compare May 8, 2025 16:54
@quentin-sommer quentin-sommer marked this pull request as ready for review May 8, 2025 16:56
@quentin-sommer quentin-sommer mentioned this pull request May 8, 2025
Closed
2 tasks
@quentin-sommer quentin-sommer force-pushed the main branch 2 times, most recently from 99f6fa4 to cd2c47a Compare May 12, 2025 13:14
@potiuk potiuk added this to the Airflow 3.0.2 milestone May 12, 2025
@quentin-sommer
Copy link
Contributor Author

@potiuk and/or @gyli how do we move this forward? I didn't find details on the PR merge process in the contribution doc

@potiuk
Copy link
Member

potiuk commented May 22, 2025

Rebased last one time to make sure it works.

@potiuk potiuk added the backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch label May 22, 2025
@potiuk potiuk merged commit e033afa into apache:main May 22, 2025
52 checks passed
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented May 22, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

github-actions bot pushed a commit that referenced this pull request May 22, 2025
@quentin-sommer @potiuk
[v3-0-test] Make is_stdout work when sys.stdout does not have a fd (#…
c7d71e9 
…50328)

(cherry picked from commit e033afa)

Co-authored-by: Quentin Sommer <quentin-sommer@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@github-actions GitHub Actions
Copy link

Backport successfully created: v3-0-test

Status Branch Result
✅ v3-0-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 22, 2025
@quentin-sommer @potiuk
[v3-0-test] Make is_stdout work when sys.stdout does not have a fd (a…
3e1bcf4 
…pache#50328)

(cherry picked from commit e033afa)

Co-authored-by: Quentin Sommer <quentin-sommer@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk added a commit that referenced this pull request May 22, 2025
@github-actions @quentin-sommer @potiuk
[v3-0-test] Make is_stdout work when sys.stdout does not have a fd (#…
71c14b6 
…50328) (#50949)

(cherry picked from commit e033afa)

Co-authored-by: Quentin Sommer <quentin-sommer@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@quentin-sommer
Copy link
Contributor Author

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

Assignees
No one assigned
Labels
area:CLI backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch
Projects
None yet
Milestone
Airflow 3.0.2
Development

Successfully merging this pull request may close these issues.

connections_export CLI can fail when stdout doesn't have a fileno
2 participants
@quentin-sommer @potiuk








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/apache/airflow/pull/50328

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy