Content-Length: 282276 | pFad | http://github.com/angular/angular/pull/61923

3C Revert "refactor(service-worker): make `SwPush` and `SwUpdate` tree-s… by thePunderWoman · Pull Request #61923 · angular/angular · GitHub
Skip to content

Revert "refactor(service-worker): make SwPush and SwUpdate tree-s… #61923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

thePunderWoman
Copy link
Contributor

…hakable (#61670)"

This reverts commit f8c1b6e.

It caused a regression reported in #61913.

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release area: service-worker Issues related to the @angular/service-worker package labels Jun 6, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 6, 2025
@arturovt
Copy link
Contributor

arturovt commented Jun 6, 2025

I'm wondering how to capture that in unit tests to prevent a regression in the future, in case we decide to make it tree-shakable again.

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 29e892a.

The changes were merged into the following branches: main, 20.0.x

AndrewKushnir pushed a commit that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: service-worker Issues related to the @angular/service-worker package target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/angular/angular/pull/61923

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy