-
Notifications
You must be signed in to change notification settings - Fork 2k
[AG-10176] Maintenance(ag-grid): first take on automating measuring performance #10687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sdwvit
wants to merge
24
commits into
latest
Choose a base branch
from
sdwvit/maintenance/ag-grid/performance-record-track-performance-changes/AG-10176
base: latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[AG-10176] Maintenance(ag-grid): first take on automating measuring performance #10687
sdwvit
wants to merge
24
commits into
latest
from
sdwvit/maintenance/ag-grid/performance-record-track-performance-changes/AG-10176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update performance test to use computeStats for result analysis
- Remove unnecessary page reload during performance tests
- do not bail
- Changed number of iterations from 10 to 50 - Modified data structure and url pairs handling in the test - Added function for reporting performance statistics in detail - Updated headless setting to consider customized environment variable
- Adjusted cookie path based on the specific URL pathname - Cleared cookies before setting new 'paccept' cookie - Refactored checking for 'Athlete' text content display in performance test.
seanlandsman
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.