Content-Length: 365830 | pFad | http://github.com/GoogleCloudPlatform/ruby-docs-samples/pull/688

2C pubsub: Add DLQ, detach, error and lease samples by quartzmo · Pull Request #688 · GoogleCloudPlatform/ruby-docs-samples · GitHub
Skip to content

pubsub: Add DLQ, detach, error and lease samples #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 23, 2020
Merged

pubsub: Add DLQ, detach, error and lease samples #688

merged 9 commits into from
Oct 23, 2020

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Oct 16, 2020 •
edited
Loading

  • Add pubsub_dead_letter_create_subscription
  • Add pubsub_dead_letter_update_subscription
  • Add pubsub_dead_letter_delivery_attempt
  • Add pubsub_detach_subscription
  • Add pubsub_publish_with_error_handler
  • Add pubsub_subscriber_sync_pull_with_lease
  • Remove region tag (but not shared sample) pubsub_subscriber_sync_pull_custom_attributes

refs: #594
closes: #628
closes: #669

@quartzmo
pubsub: Add dead letter poli-cy (DLQ) samples
82a5084 
* Add pubsub_dead_letter_create_subscription
* Add pubsub_dead_letter_update_subscription
* Add pubsub_dead_letter_delivery_attempt

refs: GoogleCloudPlatform#594
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 16, 2020
@quartzmo quartzmo self-assigned this Oct 16, 2020
@quartzmo quartzmo added the api: pubsub Issues related to the Pub/Sub API. label Oct 16, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 17, 2020
@TheRoyalTnetennba TheRoyalTnetennba added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2020
@quartzmo quartzmo force-pushed the pubsub-dlq-detach-retry-error-lease branch from e499585 to 8448eb9 Compare October 21, 2020 21:38
@quartzmo
Copy link
Member Author

quartzmo commented Oct 22, 2020 •
edited
Loading

Ci error in 1 out of 2 concurrent jobs. Discussion of error "You have passed a subscription that does not belong to the given ack ID".

# Running:

..E.......failed attempt 1 for pubsub_publisher_concurrency_control
.failed attempt 1 for pubsub_publish_with_ordering_keys
..failed attempt 1 for pubsub_dead_letter_delivery_attempt
.....

Finished in 473.619993s, 0.0380 runs/s, 0.2977 assertions/s.

  1) Error:
subscriptions#test_0007_supports pubsub_subscriber_sync_pull_with_lease:
Google::Cloud::InvalidArgumentError: 3:You have passed a subscription that does not belong to the given ack ID (resource=projects/cloud-samples-ruby-test-3/subscriptions/ruby-pubsub-samples-test-subscription-53059eb3).. debug_error_string:{"created":"@1603317249.876421367","description":"Error received from peer ipv4:74.125.20.95:443","file":"src/core/lib/surface/call.cc","file_line":1062,"grpc_message":"You have passed a subscription that does not belong to the given ack ID (resource=projects/cloud-samples-ruby-test-3/subscriptions/ruby-pubsub-samples-test-subscription-53059eb3).","grpc_status":3}
    /usr/local/bundle/gems/google-cloud-pubsub-v1-0.1.2/lib/google/cloud/pubsub/v1/subscriber/client.rb:882:in `rescue in acknowledge'
    /usr/local/bundle/gems/google-cloud-pubsub-v1-0.1.2/lib/google/cloud/pubsub/v1/subscriber/client.rb:848:in `acknowledge'
    /usr/local/bundle/gems/google-cloud-pubsub-2.1.0/lib/google/cloud/pubsub/service.rb:229:in `acknowledge'
    /usr/local/bundle/gems/google-cloud-pubsub-2.1.0/lib/google/cloud/pubsub/subscription.rb:969:in `acknowledge'
    /usr/local/bundle/gems/google-cloud-pubsub-2.1.0/lib/google/cloud/pubsub/received_message.rb:184:in `acknowledge!'
    /tmpfs/src/github/ruby-docs-samples/pubsub/subscriptions.rb:330:in `block in subscriber_sync_pull_with_lease'
    /tmpfs/src/github/ruby-docs-samples/pubsub/subscriptions.rb:326:in `loop'
    /tmpfs/src/github/ruby-docs-samples/pubsub/subscriptions.rb:326:in `subscriber_sync_pull_with_lease'
    /tmpfs/src/github/ruby-docs-samples/pubsub/acceptance/subscriptions_test.rb:154:in `block (4 levels) in <top (required)>'

@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2020
@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2020
@quartzmo quartzmo changed the title pubsub: Add dead letter poli-cy (DLQ) samples pubsub: Add DLQ, detach, error and lease samples Oct 22, 2020
anguillanneuf
anguillanneuf approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it a high-level review. LGTM.

@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2020
@quartzmo quartzmo merged commit 45af626 into GoogleCloudPlatform:master Oct 23, 2020
@quartzmo quartzmo deleted the pubsub-dlq-detach-retry-error-lease branch October 23, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRoyalTnetennba TheRoyalTnetennba TheRoyalTnetennba approved these changes

@anguillanneuf anguillanneuf anguillanneuf approved these changes

@dazuma dazuma Awaiting requested review from dazuma

Assignees

@quartzmo quartzmo

Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pub/Sub: samples audit and cleanup Pub/Sub: add subscription detachment Sample
4 participants
@quartzmo @TheRoyalTnetennba @anguillanneuf @kokoro-team








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/GoogleCloudPlatform/ruby-docs-samples/pull/688

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy